-
Notifications
You must be signed in to change notification settings - Fork 247
Conversation
Codecov Report
@@ Coverage Diff @@
## master #173 +/- ##
=====================================
Coverage 100% 100%
=====================================
Files 3 3
Lines 63 64 +1
Branches 14 15 +1
=====================================
+ Hits 63 64 +1
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks fine to me. But to be perfectly honest I feel like I've sorta lost control of this project, so I'd really appreciate it if someone else reviews this as well as a sanity check because this thing has become way more complicated than it ever should have I feel...
Come to think of it, did you try to use |
I didn't try For my particular issue I've just stopped using What I type normally
But when I need to run with a UNC path then I have to do whatever
|
Well, it seems reasonable to me. If this breaks anyone, I'm really sorry. Please offer to help maintain the project :) |
see #167
Not really sure what you want the solution to be. Apparently you want cross-env to use backlash as an esapce character even though Windows itself does not do this. So, this patch lets esaped backslashes through so if you want to pass
\\someshare\somefolder
you'd have to pass\\\\someshare\\somefolder
as the argument.also i tried running
npm run add-contributor
but appearently it doesn't work at the momentWhat: allow backslashes through
Why: beacuse otherwise you can't pass backslash through and can not specify UNC paths
How: adjust the regular expression related to backslashes
Checklist: