Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Cypress peer dependency to 13 #259

Merged
merged 1 commit into from
Sep 12, 2023

Conversation

marktnoonan
Copy link
Contributor

Hi! Let me know if you want to wait until closer to release to merge this, I just wanted to flag that 13 is coming, I do not have a definitive release date. I have seen no problems with Testing Library in the pre-release of the new version and there's nothing that seems like it would cause a problem. Just wanted to let you know that a new major is coming soon-ish.

What:

Cypress 13 is coming soon, it will include some breaking changes to Cypress but nothing that breaks Cypress Testing Library.

Why:
Avoid peer dependency warnings when people upgrade.

How:

Checklist:

  • Documentation
  • Tests
  • Ready to be merged

Copy link

@davereid davereid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nrutman
Copy link

nrutman commented Aug 30, 2023

@NicholasBoll any thoughts on getting this merged by the team? It's blocking upgrades to Cypress 13 for anyone who uses Cypress Testing Library.

@Lasidar
Copy link

Lasidar commented Aug 31, 2023

We are waiting on this fix as well for our upgrade to Cypress 13

@vicwomg
Copy link

vicwomg commented Sep 5, 2023

Note that if you're running into issues with cypress-io/github-action , you can temporarily work around it by overriding the install command in the workflow file to ignore peer deps in the install-command parameter:

- name: Cypress e2e run
        id: cypress_e2e_run
        uses: cypress-io/github-action@v6.4.0
        with:
          # Override install because Cypress upgrades break peer deps of other packages
          install-command: npm ci --legacy-peer-deps
          install: true
          browser: chrome
          # `Record: true` sends results to Cypress Dashboard
          record: true
          parallel: true

@istr
Copy link

istr commented Sep 6, 2023

For the time being, you might as well override the peer dependency in your root package.json. Minimal working example:

{
  "devDependencies": {
    "@testing-library/cypress": "9.0.0",
    "cypress": "13.1.0"
  },
  "overrides": {
    "@testing-library/cypress": {
      "cypress": "^13.0.0"
    }
  }
}

Dependency tree:

npm list
cyp-test-foo@ /home/istr/cyp-test-foo
├── @testing-library/cypress@9.0.0 overridden
└── cypress@13.1.0 overridden

@ray-peters
Copy link

Hey team, any blockers on this front? Is there anything we can do to help move this update along?

@PowerSupply
Copy link

Is this moving forwards?

@nrutman
Copy link

nrutman commented Sep 12, 2023

@NicholasBoll @kentcdodds is anything holding this up from being merged? It's preventing people from upgrading to Cypress 13 if they use your package.

@davepar
Copy link

davepar commented Sep 12, 2023

Also hit this problem after upgrading to Cypress v13.

@kentcdodds kentcdodds merged commit 876b29e into testing-library:main Sep 12, 2023
5 checks passed
@nrutman
Copy link

nrutman commented Sep 12, 2023

Thank you @kentcdodds!!

@github-actions
Copy link

🎉 This PR is included in version 10.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@Kocal
Copy link

Kocal commented Sep 13, 2023

Thanks for merging :)

This was referenced Sep 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.