feat(jest-dom): add new rule from jest-dom

[benmonro]

added a new rule to the jest-dom plugin

[MichaelDeBoey]

@benmonro This change requires ESLint 7.x, which will only be possible after #64 is merged

[benmonro]

Actually the plugin works fine on 7. I run it with 6 on a huge code base (Walmart.com) we bumped the per dep artificially in the plugin but it's not using any of the breaking changes in 7. If it's problematic I'll roll back the peer dep on the plugin to 6. I'm relying on Kent's config so kinda need this ASAP

[benmonro]

@MichaelDeBoey if you look at the breaking changes in 7, eslint-plugin-jest-dom is not affected by any of those things and in fact they only make it better for 6 (w/ improvements to the RuleTester etc). Most of them honestly only end user config but the plugins all still work.

I'm going to change eslint-plugin-jest-dom to support 6 & 7

[benmonro]

@MichaelDeBoey @kentcdodds eslint-plugin-jest-dom now supports both eslint 6.8 & 7+: testing-library/eslint-plugin-jest-dom#77

its running all the tests against both versions now as of 3.2.1.

[kentcdodds]

Cool, I'm into it 👍

[kentcdodds]

@all-contributors please add @benmonro for code

[allcontributors]

@kentcdodds

I've put up a pull request to add @benmonro! 🎉

[kentcdodds]

I'm relying on Kent's config so kinda need this ASAP

Please keep in mind that any package of mine that includes kentcdodds or kcd in the title is intended for my own use and is open source mostly for my own convenience. I'm happy to have other folks use it, but it may be better to simply fork it because I don't consider other users when maintaining these types of packages (like I do with other packages that I maintain).

Thanks for your help!

[benmonro]

fair enough. :)

…

On Mon, Aug 31, 2020 at 10:04 AM Kent C. Dodds ***@***.***> wrote: I'm relying on Kent's config so kinda need this ASAP Please keep in mind that any package of mine that includes kentcdodds or kcd in the title is intended for my own use and is open source mostly for my own convenience. I'm happy to have other folks use it, but it may be better to simply fork it because I don't consider other users when maintaining these types of packages (like I do with other packages that I maintain). Thanks for your help! — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#73 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AADBPBEEMOJOX2TEGY24KUDSDPJZLANCNFSM4QQBJJXA> .

-- Ben Monro Software Developer

[kentcdodds]

🎉 This PR is included in version 14.16.0 🎉

The release is available on:

• npm package (@latest dist-tag)
• GitHub release

Your semantic-release bot 📦🚀