Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] GridLayer grid tiles overlapping, render issue. #1475

Open
BremzeLV opened this issue May 11, 2021 · 6 comments
Open

[Bug] GridLayer grid tiles overlapping, render issue. #1475

BremzeLV opened this issue May 11, 2021 · 6 comments
Labels
bug Something isn't working

Comments

@BremzeLV
Copy link

BremzeLV commented May 11, 2021

Describe the bug
When Rendering Grid Layer, if I use data that is close toghether then it renders okay. About 10 datapoints somewhere in Berlin:
image

If I add one more Item to the dataset that is somewhere far away from the first 10 datapoints, it renders with overlapping grid layers. For example points: "latitude": 1.520008, "longitude": 179.404954
image

To load data I pass it to processRowObject() then KeplerGlSchema.load() and then addDataToMap().
Map is rendered before we get data and after that its updating map styles, configs and adding data.

Expected behavior
Would render without overlapping

Screenshots
If applicable, add screenshots to help explain your problem.

Desktop (please complete the following information):

  • OS: [e.g. iOS] Windows
  • Browser [e.g. chrome, safari] Chrome
  • Version [e.g. 22] Version 90.0.4430.93

Additional context
Its not this dataset specific problem, it can be reproduced with different datasets too.

May be linked to this one #887

@BremzeLV BremzeLV added the bug Something isn't working label May 11, 2021
@chrisgervang
Copy link
Collaborator

Thanks! Adding the relevant slack thread with more pictures. https://kepler-gl.slack.com/archives/CLTV06E20/p1620476006015600

@chrisgervang
Copy link
Collaborator

image

@ibgreen
Copy link
Collaborator

ibgreen commented May 11, 2021

@igorDykhta FYI

@igorDykhta
Copy link
Collaborator

I guess it is a known issue when the size of cells is calculated based on the center of the grid and doesn't take into account Mercator distortion. Tried to fix this previously but cells closer to poles are getting too rectangular.

@BremzeLV
Copy link
Author

BremzeLV commented May 11, 2021

I guess it is a known issue when the size of cells is calculated based on the center of the grid and doesn't take into account Mercator distortion. Tried to fix this previously but cells closer to poles are getting too rectangular.

The one question is why its happening longitudinally, wouldnt that distort more laterally? And they are not getting really rectangular, they just move out of grid "bounds". @igorDykhta

In the first image it isnt distorted, its a good render of an grid containing 1x2 grid tiles in 4sets. in 2nd image the blocks move to left or right and its the same dataset. Not sure if the Mercator distortion would do that.

@BremzeLV
Copy link
Author

Maybe there is a way to render based on multiple center points? Like subpoints for every subset of data cluster on the map? The closer the center the better rendering.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

4 participants