Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MapLibre support #2460

Closed
birkskyum opened this issue Nov 30, 2023 · 4 comments · Fixed by #2461
Closed

MapLibre support #2460

birkskyum opened this issue Nov 30, 2023 · 4 comments · Fixed by #2461

Comments

@birkskyum
Copy link
Collaborator

Is your feature request related to a problem? Please describe.
There is currently no way to use MapLibre with kepler.gl, thus demanding users to find a mapbox api key in order to use this tool, and limiting the options for using kepler.gl in an air-gapped environment.

Describe the solution you'd like
Since Kepler.gl and Deck.gl are free and open source, it would be great to have a way to use kepler.gl with free and open source MapLibre, similar to how react-map-gl and deck.gl allow for it.

Describe alternatives you've considered
Currently, only solution is for users to fork kepler.gl and swap mapbox-gl with maplibre-gl.

@ibgreen
Copy link
Collaborator

ibgreen commented Nov 30, 2023

@birkskyum Good to hear from you. This is a good proposal that we'd love to see in kepler.

Currently, only solution is for users to fork kepler.gl and swap mapbox-gl with maplibre-gl.

This comment gives me a sense that your team has already done this (or are planning to do this) in your own fork. If so would you be willing to make a PR on kepler to help us maintainers out?

We are working hard at the moment on getting kepler.gl 3.0 out the door... and if this landed soon we could add it to kepler.gl 3.0 release notes!

@birkskyum
Copy link
Collaborator Author

Great to hear. In the past I've been replacing mapbox directly with maplibre. If the desire for kepler.gl is to have both mapbox/maplibre as user-selected options through i.e. a peerDependency, that goes a bit beyond what I've been doing so far.

@ibgreen
Copy link
Collaborator

ibgreen commented Nov 30, 2023

Good point.

Longer term there is indeed a desire to allow for pluggable base map renderers including the new vis.gl bindings for Google Maps. We might even want users to be able to switch between various basemap renderers at run-time.

But that will require a bigger effort.

So for now I think yes, it makes total sense to make maplibre the default basemap, and since this could affect some users, a major release like 3.0 would be a good release to make this "breaking" change.

(Of course it would be good if we made it easy for users to in their custom builds replace maplibre with mapbox, if that doesn't require too much extra work).

@birkskyum
Copy link
Collaborator Author

Sounds like a good plan. I'll get to work on a PR to replace the default, and then down the line I agree it would be beneficial to make kepler more basemap agnostic with the various bindings. I haven't seen the Google Maps bindings before now, but it's great to see progress there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants