Fix sdk records test case in record mode #63
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Sure @developer-diganta, can you point me to some other issues in the meantime? Would be really kind of you 🚀 |
re-Tick
reviewed
Mar 10, 2023
re-Tick
reviewed
Mar 11, 2023
|
Are there any more changes required on this PR or should I add this in the completed tasks list? @re-Tick |
|
@frey0-0 please add link to this PR in GSOC/2023 ts-sdk task list corresponding to its issue. |
|
Done! |
developer-diganta
added
Don't Merge
Hey @frey0-0 ! Congrats on completing this PR! Also, you can try out the other tasks in the task list for typescript sdk or any other project that you would want to contribute to! |
Signed-off-by: Tanmay Bajaj <tanmaybajaj567@gmail.com>
… and mode is test Signed-off-by: Tanmay Bajaj <tanmaybajaj567@gmail.com>
Signed-off-by: Tanmay Bajaj <tanmaybajaj567@gmail.com>
Signed-off-by: Tanmay Bajaj <tanmaybajaj567@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #430
TS-SDK was saving tests in
testmode also which shouldn't be the case, it should only save tests in therecordmode.I have figured out the correct location to apply the correct if condition.