Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The master branch commit doesn't update in Codecov #19264

Closed
james77777778 opened this issue Mar 7, 2024 · 6 comments · Fixed by #19312, #19319 or #19320
Closed

The master branch commit doesn't update in Codecov #19264

james77777778 opened this issue Mar 7, 2024 · 6 comments · Fixed by #19312, #19319 or #19320
Assignees
Labels

Comments

@james77777778
Copy link
Contributor

Please refer to: https://app.codecov.io/gh/keras-team/keras/commits

Due to this issue, the codecov report is noisy.

@james77777778 james77777778 changed the title The master branch commit doesn't update in Codecov. The master branch commit doesn't update in Codecov Mar 7, 2024
@SuryanarayanaY SuryanarayanaY added keras-team-review-pending Pending review by a Keras team member. type:Bug labels Mar 11, 2024
@mattdangerw mattdangerw removed the keras-team-review-pending Pending review by a Keras team member. label Mar 14, 2024
@haifeng-jin
Copy link
Contributor

It is because the dependent bot updated the codecov GitHub action version from v3 to v4.
https://github.com/keras-team/keras/pull/19129/files#diff-2702f6f7d10a1bffbc8596d1a9925b1234bc4c7a6ff4c21ca6b34c13aa75780eL83-R83

V4 stopped supporting tokenless upload.
I will figure out if adding back the token would fix it.

Copy link

Are you satisfied with the resolution of your issue?
Yes
No

@james77777778
Copy link
Contributor Author

It is because the dependent bot updated the codecov GitHub action version from v3 to v4. https://github.com/keras-team/keras/pull/19129/files#diff-2702f6f7d10a1bffbc8596d1a9925b1234bc4c7a6ff4c21ca6b34c13aa75780eL83-R83

V4 stopped supporting tokenless upload. I will figure out if adding back the token would fix it.

After #19312 , the new commits are still missing from https://app.codecov.io/gh/keras-team/keras/commits
Consequently, the codecov report remains noisy...
Ex: https://app.codecov.io/gh/keras-team/keras/pull/19313 (a report of the PR after the fix)

@haifeng-jin haifeng-jin reopened this Mar 15, 2024
@haifeng-jin
Copy link
Contributor

We do not have a good fix yet. Probably, I should just downgrade it to v3.

Copy link

Are you satisfied with the resolution of your issue?
Yes
No

@adamjstewart
Copy link

FYI, TorchGeo has also been fighting against codecov for a while now. codecov-action@v3 only works a fraction of the time, and codecov-action@v4 doesn't work at all due to the token requirements. There are dozens of issues related to this, but codecov/feedback#126 has the most detailed discussion. We're at the point where we're considering abandoning codecov entirely, but if the Keras team finds a better solution let me know.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
5 participants