Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Notify user of current job's progress in output #29

Open
jacksongoode opened this issue May 20, 2021 · 5 comments
Open

Notify user of current job's progress in output #29

jacksongoode opened this issue May 20, 2021 · 5 comments
Labels
enhancement New feature or request

Comments

@jacksongoode
Copy link

How would one go about running client.process and then continuing once complete? It seems anything after the process is discarded.

@kermitt2
Copy link
Owner

Hello @jacksongoode !
Not sure I understand the question... this is a client and the GROBID server remain "warm". The client just sends PDF and gets back XML, what exactly would be hold by a client here?

@jacksongoode
Copy link
Author

Ahh, I see. I managed to get everything working but was confused with the lack of output even with the verbose flag. Would it be possible to capture the status of the current job through the python client?

@jacksongoode jacksongoode changed the title Holding up Python script Notify user of current job's progress in output May 22, 2021
@kermitt2
Copy link
Owner

Would it be possible to capture the status of the current job through the python client?

Yes sure, we could extend the "verbose" mode to make it more readable and useful. Which information would like to see?

We could prefix by file name/path and indicate "sent", "output written", things like that maybe? But usually queries are in parallel and pretty fast, it might be a console mess.

In another issue we discussed having a progress bar, but it means counting the files in a first pass and thus slowing down a bit the process, in particular if we consider folder with millions of PDF (which is a real world usage in my case). It could be optional?

@jacksongoode
Copy link
Author

jacksongoode commented May 24, 2021

Yes, I think something along the lines of a tqdm style progress bar would be really nice. I'm currently working with ~2k PDFs so printing each to console would be a mess.

But for a lot of users, the long pause in the script might causes some concern if they aren't aware that Grobid is doing its job.

@kermitt2 kermitt2 added the enhancement New feature or request label Jun 9, 2021
@jacksongoode
Copy link
Author

In addition to this feature, I am also curious if it makes sense to suppress the output when the file exists unless verbose is specified?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants