libbpf: use strlcpy() in path resolution fallback logic

anakryiko · Kernel Patches Daemon · commit 35533dc7474f · 2022-04-07T21:03:18.000-07:00
Coverity static analyzer complains that strcpy() can cause buffer
overflow. Use libbpf_strlcpy() instead to be 100% sure this doesn't
happen.

Signed-off-by: Andrii Nakryiko &lt;andrii@kernel.org&gt;
diff --git a/tools/lib/bpf/usdt.c b/tools/lib/bpf/usdt.c
@@ -456,7 +456,7 @@ static int parse_lib_segs(int pid, const char *lib_path, struct elf_seg **segs,
 	if (!realpath(lib_path, path)) {
 		pr_warn("usdt: failed to get absolute path of '%s' (err %d), using path as is...\n",
 			lib_path, -errno);
-		strcpy(path, lib_path);
+		libbpf_strlcpy(path, lib_path, sizeof(path));
 	}
 
 proceed:

Original file line number	Diff line number	Diff line change
`@@ -456,7 +456,7 @@ static int parse_lib_segs(int pid, const char lib_path, struct elf_seg *segs,`
`456`	`456`	`if (!realpath(lib_path, path)) {`
`457`	`457`	`pr_warn("usdt: failed to get absolute path of '%s' (err %d), using path as is...\n",`
`458`	`458`	`lib_path, -errno);`
`459`		`- strcpy(path, lib_path);`
	`459`	`+ libbpf_strlcpy(path, lib_path, sizeof(path));`
`460`	`460`	`}`
`461`	`461`
`462`	`462`	`proceed:`