selftests/bpf: Delete duplicate verifier/atomic_invalid tests

peilin-ye · Kernel Patches Daemon · commit 14eb3238e46e · 2024-12-20T17:34:34.000-08:00
Right now, the BPF_ADD and BPF_ADD | BPF_FETCH cases are tested twice: #55/u atomic BPF_ADD access through non-pointer OK #55/p atomic BPF_ADD access through non-pointer OK #56/u atomic BPF_ADD | BPF_FETCH access through non-pointer OK #56/p atomic BPF_ADD | BPF_FETCH access through non-pointer OK #57/u atomic BPF_ADD access through non-pointer OK #57/p atomic BPF_ADD access through non-pointer OK #58/u atomic BPF_ADD | BPF_FETCH access through non-pointer OK #58/p atomic BPF_ADD | BPF_FETCH access through non-pointer OK Reviewed-by: Josh Don <joshdon@google.com> Signed-off-by: Peilin Ye <yepeilin@google.com>
diff --git a/tools/testing/selftests/bpf/verifier/atomic_invalid.c b/tools/testing/selftests/bpf/verifier/atomic_invalid.c
@@ -13,8 +13,6 @@
 	}
 __INVALID_ATOMIC_ACCESS_TEST(BPF_ADD),
 __INVALID_ATOMIC_ACCESS_TEST(BPF_ADD | BPF_FETCH),
-__INVALID_ATOMIC_ACCESS_TEST(BPF_ADD),
-__INVALID_ATOMIC_ACCESS_TEST(BPF_ADD | BPF_FETCH),
 __INVALID_ATOMIC_ACCESS_TEST(BPF_AND),
 __INVALID_ATOMIC_ACCESS_TEST(BPF_AND | BPF_FETCH),
 __INVALID_ATOMIC_ACCESS_TEST(BPF_OR),

Original file line number	Diff line number	Diff line change
`@@ -13,8 +13,6 @@`
`13`	`13`	`}`
`14`	`14`	`__INVALID_ATOMIC_ACCESS_TEST(BPF_ADD),`
`15`	`15`	`__INVALID_ATOMIC_ACCESS_TEST(BPF_ADD \| BPF_FETCH),`
`16`		`-__INVALID_ATOMIC_ACCESS_TEST(BPF_ADD),`
`17`		`-__INVALID_ATOMIC_ACCESS_TEST(BPF_ADD \| BPF_FETCH),`
`18`	`16`	`__INVALID_ATOMIC_ACCESS_TEST(BPF_AND),`
`19`	`17`	`__INVALID_ATOMIC_ACCESS_TEST(BPF_AND \| BPF_FETCH),`
`20`	`18`	`__INVALID_ATOMIC_ACCESS_TEST(BPF_OR),`