Commit 4961d07
bpf: Clear up confusion in bpf_skb_adjust_room()'s documentation
Adding or removing room space _below_ layers 2 or 3, as the description
mentions, is ambiguous. This was written with a mental image of the
packet with layer 2 at the top, layer 3 under it, and so on. But it has
led users to believe that it was on lower layers (before the beginning
of the L2 and L3 headers respectively).
Let's make it more explicit, and specify between which layers the room
space is adjusted.
Reported-by: Rumen Telbizov <rumen.telbizov@menlosecurity.com>
Signed-off-by: Quentin Monnet <quentin@isovalent.com>
Signed-off-by: Daniel Borkmann <daniel@iogearbox.net>
Link: https://lore.kernel.org/bpf/20220812153727.224500-3-quentin@isovalent.com1 parent 54c9397 commit 4961d07
2 files changed
+8
-4
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
2573 | 2573 | | |
2574 | 2574 | | |
2575 | 2575 | | |
2576 | | - | |
| 2576 | + | |
| 2577 | + | |
2577 | 2578 | | |
2578 | 2579 | | |
2579 | | - | |
| 2580 | + | |
| 2581 | + | |
2580 | 2582 | | |
2581 | 2583 | | |
2582 | 2584 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
2573 | 2573 | | |
2574 | 2574 | | |
2575 | 2575 | | |
2576 | | - | |
| 2576 | + | |
| 2577 | + | |
2577 | 2578 | | |
2578 | 2579 | | |
2579 | | - | |
| 2580 | + | |
| 2581 | + | |
2580 | 2582 | | |
2581 | 2583 | | |
2582 | 2584 | | |
| |||
0 commit comments