usb: mtu3: use dev_err_probe to print error log about extcon

Chunfeng Yun · gregkh · commit f3ec606efc20 · 2021-06-03T13:53:04.000+02:00
Print an error log when the error number is not -EPROBE_DEFER Signed-off-by: Chunfeng Yun <chunfeng.yun@mediatek.com> Link: https://lore.kernel.org/r/1622182260-23767-4-git-send-email-chunfeng.yun@mediatek.com Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
diff --git a/drivers/usb/mtu3/mtu3_plat.c b/drivers/usb/mtu3/mtu3_plat.c
@@ -302,8 +302,8 @@ static int get_ssusb_rscs(struct platform_device *pdev, struct ssusb_mtk *ssusb)
 	if (!otg_sx->role_sw_used && of_property_read_bool(node, "extcon")) {
 		otg_sx->edev = extcon_get_edev_by_phandle(ssusb->dev, 0);
 		if (IS_ERR(otg_sx->edev)) {
-			dev_err(ssusb->dev, "couldn't get extcon device\n");
-			return PTR_ERR(otg_sx->edev);
+			return dev_err_probe(dev, PTR_ERR(otg_sx->edev),
+					     "couldn't get extcon device\n");
 		}
 	}
 

Original file line number	Diff line number	Diff line change
`@@ -302,8 +302,8 @@ static int get_ssusb_rscs(struct platform_device pdev, struct ssusb_mtk ssusb)`
`302`	`302`	`if (!otg_sx->role_sw_used && of_property_read_bool(node, "extcon")) {`
`303`	`303`	`otg_sx->edev = extcon_get_edev_by_phandle(ssusb->dev, 0);`
`304`	`304`	`if (IS_ERR(otg_sx->edev)) {`
`305`		`- dev_err(ssusb->dev, "couldn't get extcon device\n");`
`306`		`- return PTR_ERR(otg_sx->edev);`
	`305`	`+ return dev_err_probe(dev, PTR_ERR(otg_sx->edev),`
	`306`	`+ "couldn't get extcon device\n");`
`307`	`307`	`}`
`308`	`308`	`}`
`309`	`309`