libbpf: remove unneeded conversion to bool

Yang Guang · Nobody · commit f458783a51c3 · 2021-11-24T17:53:08.000-08:00
The coccinelle report
./tools/lib/bpf/libbpf.c:1644:43-48:
WARNING: conversion to bool not needed here
Relational and logical operators evaluate to bool,
explicit conversion is overly verbose and unneeded.

Reported-by: Zeal Robot &lt;zealci@zte.com.cn&gt;
Signed-off-by: Yang Guang &lt;yang.guang5@zte.com.cn&gt;
diff --git a/tools/lib/bpf/libbpf.c b/tools/lib/bpf/libbpf.c
@@ -1641,7 +1641,7 @@ static int set_kcfg_value_tri(struct extern_desc *ext, void *ext_val,
 				ext->name, value);
 			return -EINVAL;
 		}
-		*(bool *)ext_val = value == 'y' ? true : false;
+		*(bool *)ext_val = value == 'y';
 		break;
 	case KCFG_TRISTATE:
 		if (value == 'y')

Original file line number	Diff line number	Diff line change
`@@ -1641,7 +1641,7 @@ static int set_kcfg_value_tri(struct extern_desc ext, void ext_val,`
`1641`	`1641`	`ext->name, value);`
`1642`	`1642`	`return -EINVAL;`
`1643`	`1643`	`}`
`1644`		`- (bool )ext_val = value == 'y' ? true : false;`
	`1644`	`+ (bool )ext_val = value == 'y';`
`1645`	`1645`	`break;`
`1646`	`1646`	`case KCFG_TRISTATE:`
`1647`	`1647`	`if (value == 'y')`