Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement proper exception handling throughout the project #2463

Open
a-wai opened this issue Mar 18, 2024 · 0 comments
Open

Implement proper exception handling throughout the project #2463

a-wai opened this issue Mar 18, 2024 · 0 comments
Labels
critical Critical for project techdebt

Comments

@a-wai
Copy link
Contributor

a-wai commented Mar 18, 2024

Over the past few weeks, we rushed to get features working on KCIv2 and consciously ignored some engineering best practices while doing so (which is OK and is understandable given the context).

At this point, we have frequent crashes due to not handling exceptions properly, e.g. kernelci/kernelci-pipeline#468 and kernelci/kernelci-pipeline#475 being only recent examples. This affects development efforts as such crashes require immediate attention to get the system up and running again, while delaying important results.

Exceptions should be properly handled in every part of the code that could fail (including handling KeyError for every dictionary access that isn't properly guarded by a type/key existence check).

@a-wai a-wai added critical Critical for project techdebt labels Mar 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
critical Critical for project techdebt
Projects
None yet
Development

No branches or pull requests

1 participant