Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extend node.submitter #778

Merged
merged 3 commits into from
Sep 4, 2024
Merged

Extend node.submitter #778

merged 3 commits into from
Sep 4, 2024

Conversation

JenySadadia
Copy link
Collaborator

Jeny Sadadia added 3 commits September 3, 2024 18:56
src/lava_callback: set submitter for custom checkout and patchset
26063bd 
Set `node.submitter` field for `checkout` and `patchset` operation.

Signed-off-by: Jeny Sadadia <jeny.sadadia@collabora.com>
src/send_kcidb: restrict kcidb submissions
954ebc1 
Restrict KCIDB submission based on `node.submitter`
value in case of staging pipeline instance to avoid
sending custom data added with `kci_maintainer` tool.

Signed-off-by: Jeny Sadadia <jeny.sadadia@collabora.com>
src/trigger: set submitter value
d3dcbe0 
Set `node.submitter` to `service:pipeline` when
staging pipeline instance is running.

Signed-off-by: Jeny Sadadia <jeny.sadadia@collabora.com>
@JenySadadia
Copy link
Collaborator Author

@nuclearcat A couple of comments:

  • I don't think we need to set submitter for job retry operation. As it should re-run existing job and submitter info would already be set on it
  • I have used user:<email> convention for submitter field and didn't add any hash string as I guess only email would be enough to distinguish the maintainer

@nuclearcat
Copy link
Member

  • For job retry agree, it might be ok, at least for now.

  • For user:, i am wondering if having hash might make easier to trace submission, or we just should introduce new field, like treehash, for easier tree tracking.

@nuclearcat nuclearcat added this pull request to the merge queue Sep 4, 2024
Merged via the queue into kernelci:main with commit 80137c4 Sep 4, 2024
3 checks passed
@JenySadadia JenySadadia deleted the extend-submitter branch September 4, 2024 06:30
@JenySadadia JenySadadia mentioned this pull request Sep 4, 2024
Open
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nuclearcat nuclearcat Awaiting requested review from nuclearcat

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Extending usage of "submitter" field
2 participants
@JenySadadia @nuclearcat