Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some plugin icons are black on dark website — find icons that work on both light and dark mode #1294

Closed
brian-mulier-p opened this issue May 3, 2024 · 6 comments
Labels
bug Something isn't working

Comments

@brian-mulier-p
Copy link
Member

brian-mulier-p commented May 3, 2024

Describe the issue

https://kestra.io/plugins/plugin-script-shell/tasks/scripts/io.kestra.core.tasks.scripts.bash

Icons should be in light version so they are properly visible

Environment

  • Kestra Version:
  • Operating System (OS/Docker/Kubernetes):
  • Java Version (if you don't run kestra in Docker):
@brian-mulier-p brian-mulier-p added the bug Something isn't working label May 3, 2024
@anna-geller anna-geller added this to the v0.18.0 milestone May 8, 2024
@wrussell1999
Copy link
Member

@shrutimantri has made a number of PRs to convert these. However, I've realised that we need these icons to work in dark and light mode as they are also used in the Kestra UI (which can be either).

Shruti's tweaks make it so they do work on a light background but not as well as a dark icon would. I've merged one but holding off with the realisation of working on both.

kestra-io/plugin-jdbc#306
kestra-io/plugin-scripts#146
kestra-io/plugin-openai#26
kestra-io/plugin-fs#126
kestra-io/plugin-serdes#113

@brian-mulier-p
Copy link
Member Author

brian-mulier-p commented May 16, 2024

@shrutimantri please instead do this

You need to update the icon to handle black / white theme, example of wrong one, good one. The main difference is :
fill="currentColor"
that allow to change the color of the svg.
Please take care of this?

@brian-mulier-p
Copy link
Member Author

Can we revert the one you merged @wrussell1999

@wrussell1999
Copy link
Member

Reverted kestra-io/plugin-serdes#114

@anna-geller anna-geller removed this from the v0.18.0 milestone Jun 25, 2024
@anna-geller anna-geller changed the title Some plugin icons are black on dark website Some plugin icons are black on dark website — find icons that work on both light and dark mode Aug 1, 2024
@anna-geller
Copy link
Member

anna-geller commented Aug 19, 2024

will be done as part of kestra-io/kestra#4154 because we will be able to change SVG icon colors via code (e.g. revert colors)

@anna-geller anna-geller closed this as not planned Won't fix, can't repro, duplicate, stale Aug 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: Done
Development

No branches or pull requests

5 participants