Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Render HTML file outputs in the Outputs preview #5332

Open
anna-geller opened this issue Oct 7, 2024 · 7 comments
Open

Render HTML file outputs in the Outputs preview #5332

anna-geller opened this issue Oct 7, 2024 · 7 comments
Assignees
Labels
area/frontend Needs frontend code changes enhancement New feature or request good first issue Great issue for new contributors

Comments

@anna-geller
Copy link
Member

anna-geller commented Oct 7, 2024

Feature description

Adding this inside an iframe with good restrictions will allow us to add it without compromising security

id: html
namespace: company.team
tasks:
  - id: get
    type: io.kestra.plugin.core.http.Download
    uri: https://huggingface.co/datasets/kestra/datasets/resolve/main/html/forecast.html
@anna-geller anna-geller added enhancement New feature or request area/frontend Needs frontend code changes labels Oct 7, 2024
@MilosPaunovic MilosPaunovic self-assigned this Oct 7, 2024
@MilosPaunovic
Copy link
Member

The problem here is that the link form uri example, when opened on itself in the browser, renders raw html text instead of content. Example of plotly chart from here renders in both browser by itself and in the iframe. Is there any specific to the file stored here?

@Chhaya-g
Copy link

@anna-geller can I work on this feature?

@MilosPaunovic
Copy link
Member

Go for it @Chhaya-g! 🚀

@Chhaya-g
Copy link

@MilosPaunovic @anna-geller I am sorry but I have a doubt that I am expected to render the HTML, so that it looks like a webpage, right?
Also can you tell me the dedicated output preview file or section in the repository from where the task outputs would be rendered ,where I can add my vue.js code. I am a beginner with open source so could you mind clearing my doubt and helping you out?

@MilosPaunovic
Copy link
Member

You have the example flow in the description of this issue which you can use for providing the output to render. The component for outputs is in this file kestra/ui/src/components/executions/outputs/Wrapper.vue so that is where to start your search.

@Ben8t
Copy link
Member

Ben8t commented Oct 23, 2024

@Chhaya-g did you succeed to make any progress on this :) ?

@Chhaya-g
Copy link

@Chhaya-g did you succeed to make any progress on this :) ?
Hey @Ben8t, Thank you for following up. I’ve been tied up with my 7th semester practical exams all week, but I’ve reviewed everything and now have a clear understanding of how to move forward. I plan to begin working on it this weekend.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/frontend Needs frontend code changes enhancement New feature or request good first issue Great issue for new contributors
Projects
Status: In review
Development

No branches or pull requests

4 participants