Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Killing workflow executions does not work if workflow is in Retry #5983

Open
johnkm516 opened this issue Nov 19, 2024 · 1 comment
Open

Killing workflow executions does not work if workflow is in Retry #5983

johnkm516 opened this issue Nov 19, 2024 · 1 comment
Assignees
Labels
area/backend Needs backend code changes bug Something isn't working kind/customer-request Requested by one or more customers kind/pending-feedback Idea waiting for user feedback

Comments

@johnkm516
Copy link

Describe the issue

I have not tested this without subflows, therefore I do not know if this issue is exclusive to a parent workflow executing child workflows that are in retry, or if this issue exists regardless.

  1. Create a parent workflow that executes a child workflow.
  2. Have the child workflow cause an error with a retry, for example 5 times with an interval of 10s.
  3. While the child workflow is in retry, kill the parent execution (Kill parents and subflows, or kill the parent, either or it doesn't work).
  4. The parent and child workflow executions are not killed. The retry logic overrides the kill command and keeps executing.

Environment

  • Kestra Version: 0.19.10
@johnkm516 johnkm516 added area/backend Needs backend code changes area/frontend Needs frontend code changes bug Something isn't working labels Nov 19, 2024
@github-project-automation github-project-automation bot moved this to Backlog in Issues Nov 19, 2024
@MilosPaunovic MilosPaunovic removed the area/frontend Needs frontend code changes label Nov 19, 2024
@Ben8t Ben8t added the kind/customer-request Requested by one or more customers label Nov 19, 2024
@Ben8t
Copy link
Member

Ben8t commented Nov 19, 2024

Hello John, I'm not able to reproduce on kestra:develop. See the following flow and screenshot

id: parent
namespace: kestra.test

tasks:
  - id: hello
    type: io.kestra.plugin.core.log.Log
    message: Hello World! 🚀

  - id: subflow
    type: io.kestra.plugin.core.flow.Subflow
    flowId: child
    namespace: kestra.test
id: child
namespace: kestra.test

tasks:
  - id: retry
    type: io.kestra.plugin.scripts.shell.Commands
    commands:
      - sleep 5
      - exit 1
    retry:
      type: constant
      interval: PT10M
      maxAttempt: 5
    taskRunner:
      type: io.kestra.plugin.core.runner.Process

image

image

Can you provide flows to reproduce (if mines aren't complete) and screenshot please ?

@Ben8t Ben8t added the kind/pending-feedback Idea waiting for user feedback label Nov 19, 2024
@anna-geller anna-geller self-assigned this Nov 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/backend Needs backend code changes bug Something isn't working kind/customer-request Requested by one or more customers kind/pending-feedback Idea waiting for user feedback
Projects
Status: Backlog
Development

No branches or pull requests

4 participants