Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure that we don't display triggers with "flow source not found" #5998

Open
anna-geller opened this issue Nov 19, 2024 · 1 comment
Open
Labels
area/backend Needs backend code changes area/frontend Needs frontend code changes enhancement New feature or request kind/customer-request Requested by one or more customers

Comments

@anna-geller
Copy link
Member

Feature description

Automatically remove such triggers — it's quite confusing to display them if the flow no longer exists - we can consider some background cleanup process to avoid showing them

To reproduce: on the preview, we have tens of those zombie triggers https://preview-ee-kafka.kestra.io/ui/admin/triggers?size=100&page=1

image

@anna-geller anna-geller added area/backend Needs backend code changes enhancement New feature or request area/frontend Needs frontend code changes labels Nov 19, 2024
@github-project-automation github-project-automation bot moved this to Backlog in Issues Nov 19, 2024
@anna-geller anna-geller added the kind/customer-request Requested by one or more customers label Nov 19, 2024
@anna-geller
Copy link
Member Author

anna-geller commented Nov 20, 2024

From the team:

There should not be a trigger if the flow is deleted, we should delete the trigger so this may be a bug. We could add defensive code to asynchronously delete triggers that are no longer relevant when they are queried (and fix the root cause). the main issue is probably that somewhere in the code, we are deleting flow, without deleting triggers

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/backend Needs backend code changes area/frontend Needs frontend code changes enhancement New feature or request kind/customer-request Requested by one or more customers
Projects
Status: Backlog
Development

No branches or pull requests

1 participant