Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Same filter can be applied multiple times #6028

Open
smunteankestra opened this issue Nov 21, 2024 · 3 comments
Open

Same filter can be applied multiple times #6028

smunteankestra opened this issue Nov 21, 2024 · 3 comments
Assignees
Labels
area/frontend Needs frontend code changes bug Something isn't working good first issue Great issue for new contributors

Comments

@smunteankestra
Copy link
Contributor

Describe the issue

Filter duplication should no be allowed
image

Environment

  • Kestra Version: develop
@smunteankestra smunteankestra added bug Something isn't working area/backend Needs backend code changes area/frontend Needs frontend code changes labels Nov 21, 2024
@github-project-automation github-project-automation bot moved this to Backlog in Issues Nov 21, 2024
@MilosPaunovic MilosPaunovic added good first issue Great issue for new contributors and removed area/backend Needs backend code changes labels Nov 21, 2024
@kratosmy
Copy link
Contributor

Hi, @MilosPaunovic , could I take this one?

@MilosPaunovic
Copy link
Member

Absolutely, go for it @kratosmy! 🚀

Small note - it should probably be done in the callback method for the third dropdown (for values) - there's going the be needed a check if type and comparator already exist, and if the multiple selection for that comparator is enabled, then add the value, if it's not, then replace the existing value with the new one.

@kratosmy
Copy link
Contributor

Absolutely, go for it @kratosmy! 🚀当然,去吧!🚀

Small note - it should probably be done in the callback method for the third dropdown (for values) - there's going the be needed a check if type and comparator already exist, and if the multiple selection for that comparator is enabled, then add the value, if it's not, then replace the existing value with the new one.小提示 - 可能应在第三个下拉菜单(值)的回调方法中完成 - 需要检查 type 比较器是否已经存在,如果该比较器的多重选择已启用,则添加值,如果未启用,则用新值替换现有值。

thanks for your note😄

@anna-geller anna-geller moved this from Backlog to In progress in Issues Nov 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/frontend Needs frontend code changes bug Something isn't working good first issue Great issue for new contributors
Projects
Status: In progress
Development

No branches or pull requests

3 participants