Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DuckDB] Unable to upgrade to version 0.9.0 #165

Open
loicmathieu opened this issue Oct 18, 2023 · 7 comments
Open

[DuckDB] Unable to upgrade to version 0.9.0 #165

loicmathieu opened this issue Oct 18, 2023 · 7 comments
Labels
area/plugin Plugin-related issue or feature request bug Something isn't working

Comments

@loicmathieu
Copy link
Member

Issue description

See upstream issue duckdb/duckdb-java#14

@anna-geller anna-geller changed the title [DubDB] Unable to upgrade to version 0.9.0 [DuckDB] Unable to upgrade to version 0.9.0 Nov 6, 2023
@anna-geller
Copy link
Member

duckdb/duckdb-java#14

@anna-geller anna-geller added this to the v0.15.0 milestone Dec 4, 2023
@anna-geller anna-geller added the enhancement New feature or request label Dec 5, 2023
@anna-geller anna-geller modified the milestones: v0.15.0, v0.16.0 Dec 8, 2023
@loicmathieu
Copy link
Member Author

Possible workaround: rebuilding the DuckDB driver.

git clone https://github.com/duckdb/duckdb.git
git checkout v0.9.2
GEN=ninja BUILD_ICU=1 BUILD_JDBC=1 BUILD_JEMALLOC=1 BUILD_JSON=1 STATIC_LIBCPP=1  make
mvn install:install-file -Dfile=build/debug/tools/jdbc/duckdb_jdbc.jar -DgroupId=org.duckdb  -DartifactId=duckdb_jdbc -Dversion=0.9.2-custombuild -Dpackaging=jar

@richard-lennox
Copy link

Are we able to give a try updating the org.duckdb::duckdb_jdbc drivers to the 1.0.0 release? I need some feature sets from the 1.0.0 release of duckdb, but unable to use. I've reverted to using a python script in the meantime, but ideally would prefer to use this plugin.

@loicmathieu
Copy link
Member Author

@richard-lennox the upsteam issue at DuckDB side is not fixed in the new driver so we still cannot upgrade the driver

@Ben8t
Copy link
Member

Ben8t commented Oct 11, 2024

@loicmathieu @fhussonnois has a PR looking at PluginClassLoader 🤔 Does it open a new way to solve this ?
kestra-io/kestra#4621

@loicmathieu
Copy link
Member Author

@Ben8t see my comment before yours, the issue is upstream, there is nothing we can do at our side except the workaround the DuckDB team give us which is literally to build the driver by ourself and embedds our own version which is a very bad idea.

@Ben8t
Copy link
Member

Ben8t commented Oct 18, 2024

Current Workaround for Open Source Users

Note: this is the current workaround, we're looking for a solution for the upstream issue on DuckDB Java driver. Please upvote there.

  1. Fork https://github.com/kestra-io/plugin-jdbc
  2. Change plugin-jdbc-duckdb/build.gradle plugin-jdbc-duckdb/build.gradle

implementation("org.duckdb:duckdb_jdbc:0.8.1") to implementation("org.duckdb:duckdb_jdbc:<DUCKDB_VERSION>")

Then you can build plugin jar with ./gradlew shadowJar. It created a plugin-jdbc-duckdb/build/libs/plugin-jdbc-duckdb-0.<VERSION>.0.jar.

Then you can build your own version of Kestra with this built plugin (see documentation).

Alternatively, using docker-compose, you can bind volumes like this:

...
services:
  kestra:
    volumes:
      - ./libs/plugin-jdbc-duckdb-0.17.0.jar:/app/plugins/plugin-jdbc-duckdb-0.<VERSION>.0.jar
     ...

@Ben8t Ben8t added the area/plugin Plugin-related issue or feature request label Oct 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/plugin Plugin-related issue or feature request bug Something isn't working
Projects
Status: Backlog
Development

No branches or pull requests

4 participants