-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feature Request] Add support for disabling all services #126
Comments
I thought about this as well, it should be fairly easy to implement. I think we just need a super small image with curl, and a short bash script that runs 1 or 2 curl calls, then also shuts itself down. |
Are those services using balena blocks? |
Yes, but we build it ourselves |
If building ourselves, can't we edit a couple files and just leave the others as upstream? But maybe a service container better as can then handle #127 as well in same container I guess 🤔 |
I don't think we can easily mix between them. In the kiosk we just add some packages to something they have already built. Probably a service container is better. But changing the restart policy somewhat already solved this problem, if you stop it once manually, it won't restart. |
Could just add a small start.sh script here... https://github.com/ketilmo/balena-ads-b/blob/master/kiosk/Dockerfile.template Which just has the ingestion of disabled services env variable and the curl command to disable? And then just does the standard start procedure? But that's assuming not going down the service container route which is likely better I guess |
Technically we could probably replace the wifi as well similarly with their prebuilt docker image, and then do the modification. There is no real reason for us to build the whole thing. |
It might help to solve #129 as well by doing it that way instead of submodules... |
Yes, technically with #130, we should be able to modify both a little bit, and add an option to disable it and quit. |
Great discussion! Let me know if you need anything from me here. |
Currently, it's only possible to (cleanly) disable the services maintained by this project. It would be nice to be able to do that to all services, including
kiosk
andwifi-connect
.The following balena feature request is related: Add option to permanently stop/disable containers
The text was updated successfully, but these errors were encountered: