Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When you die, items are lost or moved. #336

Open
2 of 6 tasks
Xiantrius opened this issue Aug 20, 2024 · 19 comments
Open
2 of 6 tasks

When you die, items are lost or moved. #336

Xiantrius opened this issue Aug 20, 2024 · 19 comments
Labels
S-confirmed State: This issue has been replicated correctly S-invalid issue template State: The issue template was not filled out properly or consistenly T-bug Type: Something isn't working

Comments

@Xiantrius
Copy link

Xiantrius commented Aug 20, 2024

Basic questions:

  • I am actually using ketting, and not any other software (e.g. magma)
  • I am using the latest Ketting version at the time of writing for the Minecraft version, that I am using
  • I have provided full server logs and not a crash-report
  • I have checked all items without reading.
  • I have provided proper reproduction steps
  • I have ticked all boxes

What Minecraft Version is your Server on?

1.20.1

Full Ketting Version

0.3.18

Description of behavior

No Logs or Crash Found.

Reproduction Steps

The error cannot currently be reproduced and is therefore unpredictable.

Logs

No Logs Found.

Additional context

Before the bug happens.
Vor den Bug - 17-08-2024 17-02-52

When character died and then it happens.
Nach den Bug - 17-08-2024 17-04-28

Explanation:
It's hard to describe.

The problem only occurs when the command is used.
/gamerule keepInventory false

As long as the bug is not fixed, even if it does make the game easier, the command should be used.
/gamerule keepInventory true
This prevents items from disappearing completely when you die.

When the character dies:
So the bug should still happen. The items remain in the inventory, they could be mixed up in places and some of them could be lost. If you have a mod like Corail Tombstone installed, they will NOT be placed in the gravestone. You will also NOT get a key to get the items back at the gravestone.
/gamerule keepInventory false
If it is running without a bug, the items will be scattered around. If you have a mod like Corail Tombstone installed, they will be placed in the gravestone. You will also get a key to get the items back at the gravestone.

It is still being investigated whether this is really a Ketting problem.

@Xiantrius Xiantrius added the T-bug Type: Something isn't working label Aug 20, 2024
@C0D3-M4513R C0D3-M4513R added the S-invalid issue template State: The issue template was not filled out properly or consistenly label Aug 20, 2024
@C0D3-M4513R
Copy link
Member

C0D3-M4513R commented Aug 20, 2024

If you have a mod like Corail Tombstone installed, they will NOT be placed in the gravestone. You will also NOT get a key to get the items back at the gravestone.

This happens with keepInventory true or false?
Cause the section directly below, starting with:

/gamerule keepInventory false

Makes me think that it's a keepInventory true issue?

But if that were to be the case, you would be directly contradicting yourself:

The problem only occurs when the command is used.
/gamerule keepInventory false

@C0D3-M4513R
Copy link
Member

Also: possibly related to #315

@Xiantrius
Copy link
Author

it's all there, but I'll say it again, maybe you didn't understand it.
The bug only occurs if the rule is set to false.
/gamerule keepInventory false

As long as the bug isn't fixed, I'll take it.
/gamerule keepInventory true

@C0D3-M4513R
Copy link
Member

it's all there

might be, but it's confusing to read, which is all I pointed out really.

Also please add logs. They do usually help us to understand the issue.

Also do you use any bukkit keepinv things? e.g. EssentialsX KeepInv permission?

@Xiantrius
Copy link
Author

yes, I use plugin EssentialsX v2.20.1.
But on the Magma server back then, I never had any problems with items being lost when I died. I used the same EssentialsX version then too.

@C0D3-M4513R
Copy link
Member

Magma has other issues, when it comes to dying.
It's not as simple as just saying: "But it worked on xyz Software".

@Xiantrius
Copy link
Author

I tested it again this morning with the newer chain version 3.2.1 and the bug is still there.

The items remained in the inventory.
Some items were lost.
As always, items in the inventory also moved.
The tombstone key didn't come because of this bug.

@Xiantrius
Copy link
Author

Xiantrius commented Aug 21, 2024

command is
/gamerule keepInventory false
The bug seems to have a permanent effect so far and I was able to create another analysis that might be helpful.

So if, for example, I cut down a tree or took something out of a chest or collected something, the probability is highest that these items will disappear completely when I die, but the question still remains: why do the remaining items remain in the inventory?

This mainly affects the most recently farmed items, which are at risk.
Items added via creative mode are not included.

@Xiantrius
Copy link
Author

next test with new problems here -.- !

I've removed the plugins, but the bug still only occurs now and then, but it happens. And what's more, which wasn't the case with the old game server version, I can no longer collect the grave with the key, I can't open chests, etc., which means the menus for blocks no longer open, I just can't do anything. But that's only happened since I removed the plugins and only play with mods.

I can only log in again. But as soon as I die again, everything goes crazy. What did you do? There are even more problems now.

@C0D3-M4513R C0D3-M4513R added the S-can't reproduce State: The issue could not be reproduced. More detailed/Better reproduction steps are nessesary. label Aug 21, 2024
@C0D3-M4513R
Copy link
Member

C0D3-M4513R commented Aug 21, 2024

To summarize new info from discord:

  • 0.3.22 does not fix this issue
  • This seems to be an interaction with corail tombstones and essentials.
  • It's speculated that this relates to bukkit keepinv.

@Xiantrius
Copy link
Author

Problem part 1.
I would like to play with /gamerule keepinventory false with essentialsX and corial tombstone.
I can't leave either one on.
If I leave both on and play with the gamerule keepinventory false. you lose items when you die and usually the ones you last collect in your inventory are affected in some way other than through creative mode.
As long as the problem isn't fixed, there are only 2 options for me as a player.

  1. I delete Corail Tombstone and EssentialsX but can play with /gamerule keepinventory false.

  2. . I leave Corail Tombstone and EssentialsX but can play with /gamerule keepinventory true.

Problem part 2.
If I only have the Corail Tombstone mod and EssentialsX isn't on it.

Corial Tombstone bug without EssentailsX:
When I die and want to open the tomb with the key, it doesn't work. Also, after I've clicked on the tomb, I can't activate anything or use doors, trapdoors, chests, etc. I have to log back into the game every time so that I can get my items back from the tombstone with my key and everything else works normally again.

EssentailsX bug without Corial Tombstone:
When I die, it happens that I can't get the items despite gamerule keepinventory false and in luckperm EssentailsX.keepinv < which doesn't work, even without it the problem remains that the items stay in my inventory and the items that you last collected are also partially lost, as described above, as if they weren't recorded.

@Xiantrius
Copy link
Author

Xiantrius commented Aug 25, 2024

My Fazit:
So now we're waiting for Chaining to solve the compatibility problem with Corail Tombstone. Because there are problems here without EssentialsX too. In normal Forge servers the mod works perfectly on its own.
I here come fix in v1.20.1.

I have described everything that happens:

  1. If I leave Essentials in together with Corail Tombstone.

  2. If I leave Essentials in alone.

  3. If I leave Corail Tombstone in alone.

If that is understood, then all issues are resolved and I would be happy if the problems are solved.
I would just have to make a report to EssentailsX, as it is a separate problem.

@Xiantrius
Copy link
Author

For EssentialsX seperate problem.
EssentialsX/Essentials#5920

@Xiantrius
Copy link
Author

I have no other choice, I have to delete the essentialsX and ServerSystem plugin from the server until the problem is resolved.
Spigot refuses to cooperate. I hope you can fix the bug on your own one day. I did everything I could on my part. I keep saying work together and try to fix the bug. Don't let it ruin your pride in your project. I'm not just saying this because I have this problem now, I'm doing it for all players who would like to install the server software and so that you developers don't let it get you down. If I could, I would do miracles to help you, but I'm only human.

@C0D3-M4513R C0D3-M4513R added the S-confirmed State: This issue has been replicated correctly label Aug 25, 2024
@C0D3-M4513R
Copy link
Member

C0D3-M4513R commented Aug 25, 2024

The issue occurs when gamerule keepInventory is false, bukkit keepinv is true (e.g. by using essentialsx and having essentials.keepInv perm) and having EnderIo installed.

@C0D3-M4513R C0D3-M4513R removed the S-can't reproduce State: The issue could not be reproduced. More detailed/Better reproduction steps are nessesary. label Aug 25, 2024
@JustRed23
Copy link
Member

Update: this can be reproduced with bukkit keepinventory being enabled and ender io, the reason for this is that when respawning, bukkit uses the same ServerPlayer instance instead of making a new one like vanilla does. So that would require a major rewrite

@JustRed23
Copy link
Member

For now, just disable ender io

@Xiantrius
Copy link
Author

I deactivated Enderio disabled and loaded the game with Essentials tombstone again.
I entered the following in luckperm in all groups
administrator
moderator
member

add this
That would block it. I have that in there.
- -essentials.keepinv

remove this
That would allow it. I don't have that in there.
- essentials.keepinv

problem:
Test results for me.
The problem for me is always when essentialsX is activated.

When I die...
The items still remain in the inventory
and items disappear

I have to deactivate:
essentialsX

because of the other bug I reported, also because essentialsX prevents the corail tombstone bug from causing problems.
corail tombstone

Even if it is due to EnderIO, why does it still happen that items disappear even though EnderIO is deactivated and Essentials is activated?

@C0D3-M4513R
Copy link
Member

C0D3-M4513R commented Aug 26, 2024

Pleas note that adding the -essentials.keepInv does not remove the essentials.keepInv permission.

You seem to be confused on how luckperm works.

To remove a permission from a group or user you do lp <user/group> <name> permission unset <permissionName>. To disallow a permission you do lp <user/group> <name> permission set <permissionName> false

Also please note, that your minecraft user, as well as the administrator group has essentials keepimv perms.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-confirmed State: This issue has been replicated correctly S-invalid issue template State: The issue template was not filled out properly or consistenly T-bug Type: Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants