Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error when upgrading from angular 15 to angular 16 #84

Open
arttu76 opened this issue May 5, 2023 · 3 comments · May be fixed by #85
Open

Error when upgrading from angular 15 to angular 16 #84

arttu76 opened this issue May 5, 2023 · 3 comments · May be fixed by #85

Comments

@arttu76
Copy link

arttu76 commented May 5, 2023

Got the following error when compiling after upgrading my project from angular 15 to angular 16:

Error: src/app/app.module.ts:430:9 - error NG6002: 'SimpleModalModule' does not appear to be an NgModule class.
SimpleModalModule, node_modules/ngx-simple-modal/simple-modal/simple-modal.module.d.ts
export declare class SimpleModalModule {
This likely means that the library (ngx-simple-modal) which declares SimpleModalModule is not compatible with Angular Ivy. Check if a newer version of the library is available, and update if so. Also consider checking with the library's authors to see if the library is expected to be compatible with Ivy.

Edit: migrated to https://material.angular.io/components/dialog/overview - it's okay, but in some parts not as nice as ngx-simple-modal.

@looorent looorent linked a pull request May 27, 2023 that will close this issue
@looorent
Copy link

The PR #85 fixes this issue.
In the meantime, you can test is using package @looorent/ngx-simple-modal.

@celsomtrindade
Copy link
Contributor

@arttu76 @looorent I have also created an alternative for this package, as it's not being mantained anymore. You can find it at this repository.

The main goal is to keep supporting this package and also update it keep in consistency with Angular, such as versions.

@horvathpatrik
Copy link

Any news on this issue? Is the package not maintained anymore?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants