Skip to content

Commit 348a1a7

Browse files
committed
add comments
Signed-off-by: Kai-Hsun Chen <kaihsun@anyscale.com>
1 parent eb1914c commit 348a1a7

File tree

2 files changed

+12
-1
lines changed

2 files changed

+12
-1
lines changed

python/ray/dag/dag_node.py

+7-1
Original file line numberDiff line numberDiff line change
@@ -75,7 +75,13 @@ def __init__(
7575
self.is_output_node = False
7676

7777
def _prepare_upstream_nodes(self) -> List["DAGNode"]:
78-
"""Retrieve upstream nodes and update their downstream dependencies."""
78+
"""
79+
Retrieve upstream nodes and update their downstream dependencies.
80+
81+
TODO (kevin85421): Currently, the upstream nodes and downstream nodes have
82+
circular references. Therefore, it relies on the garbage collector to clean
83+
them up.
84+
"""
7985
scanner = _PyObjScanner()
8086
upstream_nodes: List["DAGNode"] = scanner.find_nodes(
8187
[

python/ray/dag/tests/experimental/test_accelerated_dag.py

+5
Original file line numberDiff line numberDiff line change
@@ -1186,6 +1186,11 @@ def test_leaf_node_two_actors(self, ray_start_regular):
11861186

11871187

11881188
def test_output_node(ray_start_regular):
1189+
"""
1190+
This test is similar to the `test_output_node` in `test_output_node.py`, but
1191+
this test is for the accelerated DAG.
1192+
"""
1193+
11891194
@ray.remote
11901195
class Worker:
11911196
def __init__(self):

0 commit comments

Comments
 (0)