-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
invalid parcel entry points in the manifest.json file are deleted in the dist/ output #20
Comments
Hey, thanks for filing an issue. I'll have a look soon. If you have a minimal project to reproduce this behaviour, it'd greatly help! |
Here is an example repo demonstrating the generated output being removed https://github.com/jthegedus/parcel-plugin-web-extension-test |
Thanks! Will take a look at this soon :) |
I have the same problem. And found a nice workaround. (well nice-ish. Definitely only a workaround). I'm now placing symlinks in my assets directory. Parcel seems to work perfectly with those links :) |
@lhk interesting, cheers for the temp fix. |
I have a manifest file which has this field
The generated output is:
"web_accessible_resources": [],
The
woff2
files are output by Parcel from an import in one of my.css
files as expected, so I just want this value carried across to the outputmanifest.json
Importing the font files directly in
web_accessible_resources
does not work since they are included innode_modules
and the output directory is a mess:results in the output dir:
dist/__/node_modules/file-icons-js/fonts/fontawesome.woff2
the double underscore throws an error in Chrome as
_
prefixed dirs are reserved.My proposed solution here would be to validate the values before using them as parcel entry points and not remove them if they are invalid entry points.
The text was updated successfully, but these errors were encountered: