Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use tracing rather than println? #344

Open
stevefan1999-personal opened this issue Apr 10, 2023 · 0 comments
Open

Use tracing rather than println? #344

stevefan1999-personal opened this issue Apr 10, 2023 · 0 comments

Comments

@stevefan1999-personal
Copy link
Contributor

stevefan1999-personal commented Apr 10, 2023

          @kevinmehall Umm the test failed because it was running under `no_std` context, and indeed there is no `println` macro. Wonder if we should also take this out too and instead of printing to the console, let's put them all together into a `Vec<String>` or let's even structuralize it. And then we could print it out altogether in the end. This could also help external compiler tracing, but I would like to keep this into another PR.

Originally posted by @stevefan1999-personal in #338 (comment)

This mean we should use https://docs.rs/tracing/latest/tracing/#crate-feature-flags. Of course, this could mean it will have to pull in a very huge dependency...

Since most of the peg usage already implied the need of an allocator, I think this is pretty fine.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant