Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Colors for customers / projects #374

Closed
npostnik opened this issue Oct 25, 2018 · 11 comments · Fixed by #751
Closed

Colors for customers / projects #374

npostnik opened this issue Oct 25, 2018 · 11 comments · Fixed by #751
Labels
feature request good first issue good issue for your first time contribution
Milestone

Comments

@npostnik
Copy link

It would be great if customers/projects had a color field, the color can be used in time entries view. Then you can see, on which projects/customers you worked. Project color should inherit the customer color if not defined.

@kevinpapst
Copy link
Member

kevinpapst commented Nov 10, 2018

Hi @npostnik, really like the idea!

Question: I added the option to display customer and project columns next to the already existing activity columns for the timesheet view:
bildschirmfoto 2018-11-10 um 20 43 41

All of the columns can be hidden by the user, as there is not enough room on all devices:

bildschirmfoto 2018-11-10 um 20 53 40

Currently anything that is visible is blue, hidden stuff is orange (e.g. projects are hidden if they are directly set to hidden or indirectly through a hidden customer).

Do you have some input how this could be implemented?

Right now I would say:

  • use the customer color for the customer label
  • use the project color for the project label

But:

  • what about the activity? should it inherit any color?
  • what do we do about the hidden state?
  • should the colors be applied in the admin datatables (customer. project, activity) as well?
  • should the hidden state of the parent be displayed?

The simplest solution if often the best one, but I am especially unsure about the admin datatables and like to get some feedback before starting to work on this one.

Edit: ping to @jmucks and @adis1987

@maaikez
Copy link

maaikez commented Nov 11, 2018

First of all: We are very happy about Kimai v2 and very enthousiastic about the new design!

It would be very nice to have configurable colors per activity. Or per customer.
It would be great if a color is automatically chosen when creating a customer (or activity), another color than used already.
I would really like to see the colors in the calendar view as well!
The hidden state can have less opacity for example.
Maybe it is an idea that the activity automatically inherits the color of the corresponding customer, unless you override this in the settings.

When you have not so many customers and projects, showing the colors and the admin datatables would be ok. But it is a real color party when you have lots of customers, projects and activities. For my purpose, it would be nice to see the colors in the admin view (so you don't have to click somewhere to see the color). Maybe you can make it a setting. Or you add a colored 'dot' to each customer, so you don't have this color for the whole label, but only a dot in front of the customer's name (or activity or project).

@kevinpapst
Copy link
Member

@maaikez thanks for your feedback and for your PP donation 👍 I'll see what I can do

@kevinpapst kevinpapst added the good first issue good issue for your first time contribution label Mar 7, 2019
@kevinpapst
Copy link
Member

Currently working on this one, as the label cause more trouble than I anticipated in the beginning.
Please give me a quick vote which one you prefer:
Small dots
Bildschirmfoto 2019-05-02 um 17 21 03

Larger dots
Bildschirmfoto 2019-05-02 um 17 17 13
Block
Bildschirmfoto 2019-05-02 um 17 18 15
I tend to use the small dots, but let me know what you think please.

@kevinpapst kevinpapst added this to the 1.0 milestone May 2, 2019
@kevinpapst
Copy link
Member

kevinpapst commented May 2, 2019

BTW: invisible items will simply get less opacity, as suggested. I'd say that the information whether something is invisible is not important in the timesheet.

Bildschirmfoto 2019-05-02 um 17 24 37

@maaikez
Copy link

maaikez commented May 2, 2019 via email

@kevinpapst
Copy link
Member

I tried it: if the color area gets larger the colors become a quite disturbing "color party" (as you said earlier). So I will stick with the dot for now.

The calendar will be supported. But there is a small problem: I have to choose a fixed font color. Currently its white: but then you can't use light colors, as they become the background and the font becomes unreadable...

@kevinpapst
Copy link
Member

You could test the PR if you want.

@infeeeee
Copy link
Contributor

Thank you for this, it makes 'My times' much more readable.

But I think the colors should show up on the last activities dropdown as well. The best would be with a colored dot just like on 'my times', but inline. It would make the dropdown consistent with my times, and easier to use.

Should I open a new issue for this?

@kevinpapst
Copy link
Member

@infeeeee yes, please a new issue. And if possible, include some kind of mockup, because I am not sure if I completely understood how the final outcome should look like.

@lock
Copy link

lock bot commented Jul 22, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. If you use Kimai on a daily basis, please consider donating to support further development of Kimai.

@lock lock bot locked and limited conversation to collaborators Jul 22, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
feature request good first issue good issue for your first time contribution
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants