Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactored javascript to ES6 classes #759

Merged
merged 14 commits into from
May 6, 2019
Merged

refactored javascript to ES6 classes #759

merged 14 commits into from
May 6, 2019

Conversation

kevinpapst
Copy link
Member

@kevinpapst kevinpapst commented May 5, 2019

Description

Refactored Kimai Javascript Code to ES6 classes.

Sneaked also in:

  • every click on an action button in the user table resulted in opening the edit dialog
  • fix active entries: hours have no leading zero
  • fix overflown duration in active entries

Types of changes

  • Breaking change:
    • for plugins which used the Kimai JS layer (none known)
    • for users of unsupported browser like IE
  • Bug fix (non-breaking change which fixes an issue)

Checklist

  • I agree that this code is used in Kimai and will be published under the MIT license

@kevinpapst kevinpapst added the bug label May 5, 2019
@kevinpapst kevinpapst added this to the 1.0 milestone May 5, 2019
@kevinpapst kevinpapst changed the title fix action buttons in user table refactored javascript to ES6 classes May 5, 2019
@kevinpapst kevinpapst merged commit 98f386d into master May 6, 2019
@kevinpapst kevinpapst deleted the fix-user-edit branch May 6, 2019 13:22
@lock
Copy link

lock bot commented Jul 5, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. If you use Kimai on a daily basis, please consider donating to support further development of Kimai.

@lock lock bot locked and limited conversation to collaborators Jul 5, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant