Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix sqlite migration #881

Merged
merged 6 commits into from
Jun 30, 2019
Merged

fix sqlite migration #881

merged 6 commits into from
Jun 30, 2019

Conversation

kevinpapst
Copy link
Member

@kevinpapst kevinpapst commented Jun 25, 2019

Description

Fixes #878

Types of changes

  • Bug fix (non-breaking change which fixes an issue)

Checklist

  • I verified that my code applies to the guidelines (composer kimai:code-check)
  • I agree that this code is used in Kimai and will be published under the MIT license

@kevinpapst kevinpapst added this to the 1.0 milestone Jun 25, 2019
@codecov
Copy link

codecov bot commented Jun 25, 2019

Codecov Report

Merging #881 into master will decrease coverage by 0.17%.
The diff coverage is 22.22%.

@@             Coverage Diff              @@
##             master     #881      +/-   ##
============================================
- Coverage     94.36%   94.19%   -0.18%     
- Complexity     2570     2579       +9     
============================================
  Files           277      277              
  Lines          8017     8022       +5     
============================================
- Hits           7565     7556       -9     
- Misses          452      466      +14
Impacted Files Coverage Δ Complexity Δ
src/Doctrine/AbstractMigration.php 0% <0%> (ø) 22 <9> (+9) ⬆️
src/API/ActivityController.php 95.45% <100%> (-0.2%) 17 <1> (ø)
src/API/CustomerController.php 94.91% <100%> (-0.25%) 14 <1> (ø)
src/Doctrine/SqliteSessionInitSubscriber.php 100% <100%> (ø) 3 <0> (ø) ⬇️
src/API/ProjectController.php 91.8% <100%> (-0.39%) 15 <1> (ø)

@kevinpapst kevinpapst marked this pull request as ready for review June 28, 2019 12:05
@kevinpapst kevinpapst merged commit 834a0a8 into master Jun 30, 2019
@kevinpapst kevinpapst deleted the cleanup branch June 30, 2019 13:16
@kevinpapst kevinpapst changed the title cleanup fix sqlite migration Jun 30, 2019
@lock
Copy link

lock bot commented Aug 29, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. If you use Kimai on a daily basis, please consider donating to support further development of Kimai.

@lock lock bot locked and limited conversation to collaborators Aug 29, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Timesheets table empty after update
1 participant