Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed short invoice #891

Merged
merged 1 commit into from
Jun 30, 2019
Merged

fixed short invoice #891

merged 1 commit into from
Jun 30, 2019

Conversation

kevinpapst
Copy link
Member

@kevinpapst kevinpapst commented Jun 30, 2019

Description

Fixes #884

1 entry with rate: 100¢/h for 30 minutes
1 entry with a fixed rate of 20€

Before:
Bildschirmfoto 2019-06-30 um 15 56 12

After (ignore the changed description, this is about the rates!):
Bildschirmfoto 2019-06-30 um 16 10 39

Types of changes

  • Bug fix (non-breaking change which fixes an issue)

Checklist

  • I verified that my code applies to the guidelines (composer kimai:code-check)
  • I agree that this code is used in Kimai and will be published under the MIT license

@kevinpapst kevinpapst added the bug label Jun 30, 2019
@kevinpapst kevinpapst added this to the 1.0 milestone Jun 30, 2019
@codecov
Copy link

codecov bot commented Jun 30, 2019

Codecov Report

Merging #891 into master will increase coverage by <.01%.
The diff coverage is 100%.

@@             Coverage Diff              @@
##             master     #891      +/-   ##
============================================
+ Coverage     94.19%   94.19%   +<.01%     
  Complexity     2579     2579              
============================================
  Files           277      277              
  Lines          8022     8024       +2     
============================================
+ Hits           7556     7558       +2     
  Misses          466      466
Impacted Files Coverage Δ Complexity Δ
src/Invoice/Calculator/ShortInvoiceCalculator.php 100% <100%> (ø) 4 <0> (ø) ⬇️

@kevinpapst kevinpapst merged commit 94d68c8 into master Jun 30, 2019
@kevinpapst kevinpapst deleted the fix-short-invoice branch June 30, 2019 16:38
@lock
Copy link

lock bot commented Aug 29, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. If you use Kimai on a daily basis, please consider donating to support further development of Kimai.

@lock lock bot locked and limited conversation to collaborators Aug 29, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Invoice calculator that differs between fixed and hourly rates
1 participant