Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow to disable user preferences by permission #895

Merged
merged 5 commits into from
Jul 1, 2019

Conversation

kevinpapst
Copy link
Member

Description

Some last minute changes for 1.0

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

Checklist

  • I verified that my code applies to the guidelines (composer kimai:code-check)
  • I updated the documentation (see here)
  • I agree that this code is used in Kimai and will be published under the MIT license

@kevinpapst kevinpapst added this to the 1.0 milestone Jul 1, 2019
@codecov
Copy link

codecov bot commented Jul 1, 2019

Codecov Report

Merging #895 into master will increase coverage by <.01%.
The diff coverage is 93.75%.

@@             Coverage Diff              @@
##             master     #895      +/-   ##
============================================
+ Coverage     94.19%   94.19%   +<.01%     
- Complexity     2579     2582       +3     
============================================
  Files           277      277              
  Lines          8024     8030       +6     
============================================
+ Hits           7558     7564       +6     
  Misses          466      466
Impacted Files Coverage Δ Complexity Δ
src/EventSubscriber/UserPreferenceSubscriber.php 96.87% <ø> (-0.05%) 11 <0> (ø)
src/Twig/TitleExtension.php 100% <100%> (ø) 4 <3> (ø) ⬇️
src/EventSubscriber/ThemeOptionsSubscriber.php 96% <100%> (+3.14%) 11 <0> (ø) ⬇️
src/Voter/UserVoter.php 90.9% <100%> (ø) 16 <0> (ø) ⬇️
src/DependencyInjection/Configuration.php 98.73% <100%> (ø) 22 <0> (ø) ⬇️
src/Configuration/ThemeConfiguration.php 88.88% <80%> (-11.12%) 5 <3> (+3)

@kevinpapst kevinpapst merged commit 90980f4 into master Jul 1, 2019
@kevinpapst kevinpapst deleted the pre-release-fixes branch July 1, 2019 17:37
@kevinpapst kevinpapst changed the title Pre release fixes allow to disable user preferences by permission Jul 1, 2019
@lock
Copy link

lock bot commented Aug 30, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. If you use Kimai on a daily basis, please consider donating to support further development of Kimai.

@lock lock bot locked and limited conversation to collaborators Aug 30, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant