Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop get-proxy #11

Open
stevenvachon opened this issue Jun 1, 2017 · 1 comment
Open

Drop get-proxy #11

stevenvachon opened this issue Jun 1, 2017 · 1 comment

Comments

@stevenvachon
Copy link

It doesn't support NO_PROXY and does not take an input URL (or protocol) to discern which env var to use, as there can be multiple. Meanwhile, proxy-from-env does all of this and more.

@stevenvachon
Copy link
Author

stevenvachon commented Jun 7, 2017

I can write a PR for this, if you'd like; taking my tests from https://github.com/stevenvachon/auto-tunnel

The API would need to be changed to:

got('todomvc.com', {
	agent: caw('http://todomvc.com')
}, () => {});

…where the current first index (being a proxy URL override) would need to be changed to the request URL. This ties into #16

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant