Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Doesn't work with React 18 #42

Closed
fr-an-k opened this issue Jan 20, 2023 · 4 comments
Closed

Doesn't work with React 18 #42

fr-an-k opened this issue Jan 20, 2023 · 4 comments
Labels
dependencies Pull requests that update a dependency file

Comments

@fr-an-k
Copy link

fr-an-k commented Jan 20, 2023

Hi, looks great, just what I need. I wonder why so few people use it, but needs an upgrade to React 18 in order to survive. The deferred regl also doesn't seem to be functional.

If you don't want to update it, can you explain the approach you have taken so it's easier for the next enthusiast to fix it? And perhaps update the readme.

I will manage to roll my own, but it's for a closed source company and a modified version of React.

@kevzettler
Copy link
Owner

kevzettler commented Jan 20, 2023

Thanks for reporting @fr-an-k in the mean time you may find that https://github.com/psychobolt/react-regl
fits your needs. It is another regl react reconciler. It dosen't have the deferred pattern of this library.
I'm not sure if its compatible with react 18 either though.

@fr-an-k
Copy link
Author

fr-an-k commented Jan 22, 2023

Thanks, but it's not compatible; this is another attempt at react + REGL worthy of mentioning: https://webviz.io/worldview/#/ although higher level and using react 16

@kevzettler
Copy link
Owner

@fr-an-k I have a branch out with support for React 18 at #43 You can install this with: react-regl@5.0.0-beta.0 in package.json

I have only tested it within the local storybook but smoke tests seem ok. Please let me know if you are able to install and activate.

@kevzettler kevzettler added the dependencies Pull requests that update a dependency file label Jan 24, 2023
@fr-an-k
Copy link
Author

fr-an-k commented Jan 28, 2023

Thanks, it works!
You could update regl as well when merging.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

No branches or pull requests

2 participants