Add the possibility to set edm4hep::utils::ParticleIDMeta via the IMetadataSvc
#273
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
tmadlener
force-pushed
the
add-pid-metadata
branch
from
ff46b52 to
baecff1
Compare
|
I have added a "small" test case that runs similar checks as in the functional algorithm as a standalone application (effectively hard-coding the expected parameter and algorithm names). I have done it in c++ because the PIDHandler is not yet really usable in python (see key4hep/EDM4hep#396). Once the nightly builds have picked up key4hep/EDM4hep#395, CI should also start to pass again (tomorrow). |
tmadlener
changed the title
edm4hep::utils::ParticleIDMeta via the IMetadataSvcedm4hep::utils::ParticleIDMeta via the IMetadataSvc
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BEGINRELEASENOTES
edm4hep::utils::ParticleIDMetawith theMetadataSvcgetandputthat defer to the corresponding utility calls in EDM4hepENDRELEASENOTES
This would be option 1 sketched out in #272