Error in the javascript sample code on your website....

[pperrin]

Hi

Been trying this all out, not going too well... but nailed the main problem down to the sample code I copied from the example on your website...

On page https://keybase.io/kbpgp/docs/generating_a_pair

under 'generating a keypair' in the javascript version is shows

   console.log("private key: ", priv);

This should be

    console.log("private key: ", pgp_private);

Really easy to fix once you have found it! :)

Great code, thanks for the share - I love open source heros.

[LoulergueC]

👍 You're absolutely write.

I even dare to say that on page https://keybase.io/kbpgp/docs/encrypting

In example 1 in the javascript version it's written

kbpgp.box(params, function(err, result_string, result_buffer) {
  console.log(err, result_armored_string, result_raw_buffer);
});

But to correspond to the parameters of the function it should be

kbpgp.box(params, function(err, result_string, result_buffer) {
  console.log(err, result_string, result_buffer);
});

These are only minor issues compared to your great work. ❤️