Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleaning queue if clearCroutonsForActivity has not been called #157

Closed
jblernout opened this issue Feb 17, 2014 · 1 comment
Closed

Cleaning queue if clearCroutonsForActivity has not been called #157

jblernout opened this issue Feb 17, 2014 · 1 comment

Comments

@jblernout
Copy link

Manager.java line 210 :
if (null == activity || activity.isFinishing()) {
return;
}

Instead of just returning is isFinishing is true, I think clearCroutonsForActivity should be called with activity in parameter.

If the developer forgot to call clearCroutonsForActivity when destroying its activity, the library won't display croutons anymore event after switching to another activity and the queue will keep growing.

You could also throw an exception to let the developer know he did something wrong.

@keyboardsurfer
Copy link
Owner

Relevant for #24

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants