Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Action bar overlay? #168

Closed
aryaxt opened this issue Mar 18, 2014 · 20 comments
Closed

Action bar overlay? #168

aryaxt opened this issue Mar 18, 2014 · 20 comments
Labels

Comments

@aryaxt
Copy link

aryaxt commented Mar 18, 2014

How do you handle repositioning of a crouton when action bar overlay is on?

I have a weird case where the crouton goes below my action bar. My hacky solution for now is to add a custom view and add top padding when the action bar is visible?

Is that something that this library doesn't handle automatically? or am I doing something wrong?

Thanks

@keyboardsurfer
Copy link
Owner

I'm not quite sure what you mean by action bar overlay. But it could be a duplicate of #165

@nvanbenschoten
Copy link

I'm having the same issue when using an action bar overlay (http://developer.android.com/training/basics/actionbar/overlaying.html). Is there a way we can get the crouton to display below the translucent action bar without messing with custom views?

@goodev
Copy link

goodev commented Apr 15, 2014

Just meet this situation, I change the Manager class, the default Crouton(INFO, ALERT, CONFIRM) will show below the actionbar. see this gist: https://gist.github.com/goodev/10725271

@niqo01
Copy link
Contributor

niqo01 commented Apr 15, 2014

@keyboardsurfer This would be nice to include @goodev patch in this library

@keyboardsurfer
Copy link
Owner

Yep I think so, too. @goodev care to make a pull request on develop?

@goodev
Copy link

goodev commented Apr 17, 2014

@keyboardsurfer , I created a pull request: #174

@thedumbtechguy
Copy link

I just tried and this still persists.

Basically when the ActionBar is overlayed, the crouton is not displayed since it is hidden beneath the actionbar.

I am unable to add a margin to the top of the crouton. This I believe would sort the issue out.

@keyboardsurfer
Copy link
Owner

@frostymarvelous which version of Crouton are you using?

@keyboardsurfer
Copy link
Owner

There is a version 1.8.5 available, which is not yet deployed on maven central. The issue should be resolved in this version.

@thedumbtechguy
Copy link

Alright. Awesome! I am looking forward to it.

@ghost
Copy link

ghost commented Aug 26, 2014

I am still experiencing this. My custom view crouton is going below my custom actionbar overlay. Using version 1.8.5 from maven.

@keyboardsurfer
Copy link
Owner

You could use the new Toolbar API and attach the Crouton to that.

@philipesteiff
Copy link

Hi @keyboardsurfer, how i can attach crouton in Toolbar?

@keyboardsurfer
Copy link
Owner

You'll need to pass it's resource Id to the Crouton constructor as last parameter.

@alpeshnd
Copy link

it will show crouton little bit shifted over right side.

@ppamorim
Copy link

Not working here.
+1

@keyboardsurfer
Copy link
Owner

Can you post a screenshot of the result when attaching a Crouton to the Toolbar as described in my comment above?

@ppamorim
Copy link

Not attached:

problem

Attached: ... Not showing

@keyboardsurfer
Copy link
Owner

You probably need to fiddle around with the LayoutParams in order to get this working or might try to attach it to your ViewGroup container.

@keyboardsurfer
Copy link
Owner

See README for further info.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

9 participants