Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add release engine for Composer #490

Open
ezekg opened this issue Nov 4, 2021 · 1 comment
Open

Add release engine for Composer #490

ezekg opened this issue Nov 4, 2021 · 1 comment

Comments

@ezekg
Copy link
Member

ezekg commented Nov 4, 2021

Maybe use a php subdomain?

@ezekg ezekg changed the title Add composer support Add Composer support Nov 4, 2021
@ezekg
Copy link
Member Author

ezekg commented Nov 4, 2021

One issue with Composer is that auth is per-domain, not per-package. So multiple Keygen users could not distribute packages to the same user, since the packages would require 2 different tokens to access.

One solution would be to allow an account subdomain scope. But Heroku doesn’t seem to play well with that many custom domains. It’d also require another wildcard cert if we wanted to scope it under <account>.php.. Heroku does support wildcard subdomains, so *.php.keygen.sh or *.get.keygen.sh would work.

A better solution may be custom domains?

@ezekg ezekg changed the title Add Composer support Add release engine for Composer Sep 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant