You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Suggest to rename Uni_IsSMP() to Uni_IsNonBMP() across unicode.h and kmcompx.h as it is misleading. The SMP is exactly U+10000..U+1FFFF only. Only used in a few places.
To be honest, the name is still ambiguous: what data type does it accept? I guess it takes a USV (u)int32_t but... that's different to some of the other Uni_ macros.
The Uni_ class of macros in unicode.h could all be reviewed for better names.
Suggest to rename
Uni_IsSMP()
toUni_IsNonBMP()
across unicode.h and kmcompx.h as it is misleading. The SMP is exactly U+10000..U+1FFFF only. Only used in a few places.Discussed this at #10557.
The text was updated successfully, but these errors were encountered: