Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(core): rename Uni_IsSMP to Uni_NonBMP #10654

Open
srl295 opened this issue Feb 6, 2024 · 2 comments
Open

chore(core): rename Uni_IsSMP to Uni_NonBMP #10654

srl295 opened this issue Feb 6, 2024 · 2 comments
Assignees
Labels
chore core/ Keyman Core
Milestone

Comments

@srl295
Copy link
Member

srl295 commented Feb 6, 2024

Suggest to rename Uni_IsSMP() to Uni_IsNonBMP() across unicode.h and kmcompx.h as it is misleading. The SMP is exactly U+10000..U+1FFFF only. Only used in a few places.

Discussed this at #10557.

@srl295 srl295 added the chore label Feb 6, 2024
@srl295 srl295 added this to the 18.0 milestone Feb 6, 2024
@srl295 srl295 self-assigned this Feb 6, 2024
@keymanapp-test-bot keymanapp-test-bot bot added the core/ Keyman Core label Feb 6, 2024
@mcdurdin
Copy link
Member

mcdurdin commented Feb 6, 2024

Yes my bad, back in probably 1998. SMP stands for Some More Planes and covers everything that is not in the BMP. Doesn't it?

@mcdurdin
Copy link
Member

mcdurdin commented Feb 7, 2024

To be honest, the name is still ambiguous: what data type does it accept? I guess it takes a USV (u)int32_t but... that's different to some of the other Uni_ macros.

The Uni_ class of macros in unicode.h could all be reviewed for better names.

@mcdurdin mcdurdin modified the milestones: 18.0, A18S2 Apr 29, 2024
@mcdurdin mcdurdin modified the milestones: A18S2, A18S3, 19.0 May 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore core/ Keyman Core
Projects
None yet
Development

No branches or pull requests

3 participants