Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug(common/models): LM stops working on a fresh install #4959

Closed
MakaraSok opened this issue Apr 22, 2021 · 12 comments
Closed

bug(common/models): LM stops working on a fresh install #4959

MakaraSok opened this issue Apr 22, 2021 · 12 comments

Comments

@MakaraSok
Copy link
Collaborator

Describe the bug

With a fresh installed of Keyman for Android, after installing Khmer Angkor keyboard and NC Khmer Wordlist LM, start typing in the text area ស្រ to see no suggestion on the banner.

Expected behavior

The LM should give the expected/relevant suggestions on the banner.

Screenshots

InkedScreenshot_1619072210_LI


Keyman for Android:

  • Device: Pixel 2 (AS emulator)
  • OS: Android 10
  • Keyman version 14.0.271
  • Target application: Keyman

Keyboard

@MakaraSok
Copy link
Collaborator Author

The behavior is rather unpredictable. I experienced that the error would not happen right of the gate. The suggestions might keep showing after typing ស្រ . The LM would crash or stop giving the suggestions if the same sequence is typed over and again after choosing from the suggestions.

i.e. keep typing ស្រ and choose ស្រី (the first option) until the banner turns blank. See below. It turns blank after three rounds for me.

Screenshot_1619083180

@mcdurdin mcdurdin added this to the A15S4 milestone May 10, 2021
@mcdurdin mcdurdin changed the title bug(android): LM stops working on a fresh install bug(common/models): LM stops working on a fresh install May 10, 2021
@mcdurdin mcdurdin modified the milestones: A15S4, A15S5 May 14, 2021
@jahorton
Copy link
Contributor

It's worth noting that errors will generally be a lot more likely for models targeting languages without proper word-breaking implementations. Our support for them is simply lacking until we're able to implement #5025.

If this can be shown to also affect models for languages with space-based wordbreaking, that would give this issue higher priority.

@mcdurdin mcdurdin modified the milestones: A15S5, A15S6 May 29, 2021
@mcdurdin mcdurdin modified the milestones: A15S6, A15S7 Jun 13, 2021
@mcdurdin mcdurdin modified the milestones: A15S7, A15S8 Jun 28, 2021
@mcdurdin mcdurdin modified the milestones: A15S8, A15S9 Jul 12, 2021
@mcdurdin mcdurdin modified the milestones: A15S9, A15S10 Jul 26, 2021
@mcdurdin mcdurdin modified the milestones: A15S10, A15S11 Aug 9, 2021
@mcdurdin mcdurdin modified the milestones: A15S11, A15S12 Aug 23, 2021
@mcdurdin mcdurdin modified the milestones: A15S12, A15S13 Sep 6, 2021
@mcdurdin mcdurdin removed this from the A15S13 milestone Sep 18, 2021
@mcdurdin mcdurdin modified the milestones: B15S7, A16S1 May 3, 2022
@mcdurdin
Copy link
Member

Is that with a multi-tap backspace, rather than a held one?

Multi-tap

Also, can you replicate this in iOS? Or on the "Predictive Text: robust testing" Web test page?

I haven't had the capacity to try and replicate on other platforms yet, sorry.

@jahorton
Copy link
Contributor

While we're not sure exactly how just yet, it seems that this may have interesting interactions with Android-specific behaviors.

@mcdurdin mcdurdin modified the milestones: A16S2, A16S3 May 30, 2022
@mcdurdin mcdurdin modified the milestones: A16S3, A16S4 Jun 11, 2022
@mcdurdin mcdurdin modified the milestones: A16S4, A16S5 Jun 24, 2022
@mcdurdin mcdurdin modified the milestones: A16S5, A16S6 Jul 9, 2022
@mcdurdin mcdurdin modified the milestones: A16S6, A16S7 Jul 24, 2022
@mcdurdin mcdurdin modified the milestones: A16S7, A16S8 Aug 7, 2022
@mcdurdin mcdurdin modified the milestones: A16S8, A16S9 Aug 22, 2022
@mcdurdin mcdurdin modified the milestones: A16S9, A16S10, A16S13 Sep 5, 2022
@mcdurdin
Copy link
Member

@MakaraSok would you mind re-testing this one please?

@MakaraSok
Copy link
Collaborator Author

Tested with Keyman for Android 16.0.84-alpha on SG S9+ running Android 10. The issue cannot be reproduced. It seems to have gone away by now.

@mcdurdin
Copy link
Member

Good stuff, closing as resolved 😁

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants