Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(common): builder should make sure that dep builds are not later called as child builds and vice-versa #9744

Open
mcdurdin opened this issue Oct 11, 2023 · 0 comments

Comments

@mcdurdin
Copy link
Member

Compare the later entries in both sections; they're nigh-identical.

First set of calls: as a child script, from the top-level build.sh.

Second set: as a dependency, from web/src/test/manual, which does not include web/src/tools as a viable child-project folder.

I reckon we should consider tweaking builder.inc.sh to handle the scenario of child vs dependency calls resulting in multiple calls.

Originally posted by @mcdurdin in #9743 (comment)

@mcdurdin mcdurdin added this to the Future milestone Oct 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant