fix(developer): Project upgrade messages now show in Messages panel 🦕 #9969
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Relates to #9948. Having the project upgrade messages in the Messages panel means that users can refer to them as they clean up their projects to bring them into the v17 format.
User Test ResultsTest specification and instructions
Test Artifacts
|
keymanapp-test-bot
bot
added
the
user-test-required
69 tasks
darcywong00
reviewed
Nov 8, 2023
| Project.Log(plsError, Project.FileName, msg, 0, 0); | ||
| end; | ||
| MessageDlg('Some issues must be addressed before the current project can '+ | ||
| 'be upgraded to Keyman Developer 17 format. '+ |
There was a problem hiding this comment.
l.61 calls it "Keyman Developer 17.0 format".
Do we future-proof with Keyman Developer 17.0+ ....?
There was a problem hiding this comment.
I thought about it but I think it's a Developer 17 file format and 18 may have a new format. I'm okay with keeping it as is 😁
Test Results
..Upgrade project msg1 
..Upgrade project msg2 
..Upgrade project msg3 
|
keymanapp-test-bot
bot
removed
the
user-test-required
mcdurdin
changed the title
Base automatically changed from
fix/developer/kmc-build-ldml-create-outdir
to
master
November 15, 2023 02:47
mcdurdin
deleted the
fix/developer/9948-show-project-upgrade-messages-in-messages-panel
branch
|
Changes in this pull request will be available for download in Keyman version 17.0.211-alpha |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relates to #9948.
Having the project upgrade messages in the Messages panel means that users can refer to them as they clean up their projects to bring them into the v17 format.
Project.Upgrade.Workflow.mp4
(Note near the end of the video: the lingering messages in the messages window are now cleared.)
User Testing
TEST_UPGRADE: Try to upgrade a project to v17 format -- choose a project that has files from various locations, and observe the messages presented during upgrade. Remove the files that are not in the right folder, and then run the upgrade again. The upgrade should succeed and the Upgrade warning message should disappear.