feat(api): Add Sentry Integeration #133

HarshPatel5940 · 2024-02-10T04:40:27Z

User description

Description

This pull request adds the necessary code and configuration to integrate Sentry into the project. It includes the initialization of Sentry, the addition of Sentry handlers, and the setup of the necessary environment variables. Additionally, it includes the necessary scripts to build and upload source maps to Sentry for better error tracking and debugging.

Fixes #109

Dependencies

@sentry/profiling-node
@sentry/node

Mentions

@rajdip-b

Screenshots of relevant screens

Developer's checklist

My PR follows the style guidelines of this project
I have performed a self-check on my work
I have followed the coding guidelines
My changes in code generate no new warnings
My changes are breaking another fix/feature of the project
I have added test cases to show that my feature works
I have added relevant screenshots in my PR
There are no UI/UX issues

Documentation Update

This PR requires an update to the documentation at docs.keyshade.xyz
I have made the necessary updates to the documentation, or no documentation changes are required.

Type

enhancement, configuration changes, dependencies

Description

Integrated Sentry for error tracking and performance monitoring in the API application.
Added Sentry configuration in .env.example for easy setup.
Updated package.json to include Sentry dependencies and a script for source maps upload.
Modified tsconfig.base.json to enhance Sentry's issue grouping by adjusting source maps configuration.

Changes walkthrough

Relevant files

Enhancement

main.ts `Integrate Sentry for Enhanced Error Tracking and Performance Monitoring` apps/api/src/main.ts Initialized Sentry with environment variables and conditional enabling. Added Sentry request, tracing, and error handlers in the bootstrap function. Wrapped the application bootstrap logic within a Sentry span for better tracing.	+46/-23

Configuration changes

.env.example `Add Sentry Configuration Environment Variables` .env.example Added environment variables for Sentry DSN, traces sample rate, and profiles sample rate.	+4/-0
tsconfig.base.json `Configure TypeScript for Sentry Source Maps` tsconfig.base.json Enabled inline sources and set `sourceRoot` to improve Sentry issue grouping.	+9/-1

Dependencies

package.json `Update Dependencies and Scripts for Sentry Integration` package.json Added `@sentry/cli`, `@sentry/node`, and `@sentry/profiling-node` to dependencies. Included a new script `sentry:sourcemaps` for uploading source maps to Sentry.	+6/-2

✨ Usage guide:

Overview:
The describe tool scans the PR code changes, and generates a description for the PR - title, type, summary, walkthrough and labels. The tool can be triggered automatically every time a new PR is opened, or can be invoked manually by commenting on a PR.

When commenting, to edit configurations related to the describe tool (pr_description section), use the following template:

/describe --pr_description.some_config1=... --pr_description.some_config2=...

With a configuration file, use the following template:

[pr_description]
some_config1=...
some_config2=...

Enabling\disabling automation When you first install the app, the default mode for the describe tool is: `pr_commands = ["/describe --pr_description.add_original_user_description=true" "--pr_description.keep_original_user_title=true", ...]` meaning the `describe` tool will run automatically on every PR, will keep the original title, and will add the original user description above the generated description. Markers are an alternative way to control the generated description, to give maximal control to the user. If you set: `pr_commands = ["/describe --pr_description.use_description_markers=true", ...]` the tool will replace every marker of the form `pr_agent:marker_name` in the PR description with the relevant content, where `marker_name` is one of the following: `type`: the PR type. `summary`: the PR summary. `walkthrough`: the PR walkthrough. Note that when markers are enabled, if the original PR description does not contain any markers, the tool will not alter the description at all.
Custom labels The default labels of the `describe` tool are quite generic: [`Bug fix`, `Tests`, `Enhancement`, `Documentation`, `Other`]. If you specify custom labels in the repo's labels page or via configuration file, you can get tailored labels for your use cases. Examples for custom labels: `Main topic:performance` - pr_agent:The main topic of this PR is performance `New endpoint` - pr_agent:A new endpoint was added in this PR `SQL query` - pr_agent:A new SQL query was added in this PR `Dockerfile changes` - pr_agent:The PR contains changes in the Dockerfile ... The list above is eclectic, and aims to give an idea of different possibilities. Define custom labels that are relevant for your repo and use cases. Note that Labels are not mutually exclusive, so you can add multiple label categories. Make sure to provide proper title, and a detailed and well-phrased description for each label, so the tool will know when to suggest it.
Inline File Walkthrough 💎 For enhanced user experience, the `describe` tool can add file summaries directly to the "Files changed" tab in the PR page. This will enable you to quickly understand the changes in each file, while reviewing the code changes (diffs). To enable inline file summary, set `pr_description.inline_file_summary` in the configuration file, possible values are: `'table'`: File changes walkthrough table will be displayed on the top of the "Files changed" tab, in addition to the "Conversation" tab. `true`: A collapsable file comment with changes title and a changes summary for each file in the PR. `false` (default): File changes walkthrough will be added only to the "Conversation" tab.
Utilizing extra instructions The `describe` tool can be configured with extra instructions, to guide the model to a feedback tailored to the needs of your project. Be specific, clear, and concise in the instructions. With extra instructions, you are the prompter. Notice that the general structure of the description is fixed, and cannot be changed. Extra instructions can change the content or style of each sub-section of the PR description. Examples for extra instructions: `[pr_description] extra_instructions=""" - The PR title should be in the format: '<PR type>: <title>' - The title should be short and concise (up to 10 words) - ... """` Use triple quotes to write multi-line instructions. Use bullet points to make the instructions more readable.
More PR-Agent commands To invoke the PR-Agent, add a comment using one of the following commands: /review: Request a review of your Pull Request. /describe: Update the PR title and description based on the contents of the PR. /improve [--extended]: Suggest code improvements. Extended mode provides a higher quality feedback. /ask <QUESTION>: Ask a question about the PR. /update_changelog: Update the changelog based on the PR's contents. /add_docs 💎: Generate docstring for new components introduced in the PR. /generate_labels 💎: Generate labels for the PR based on the PR's contents. /analyze 💎: Automatically analyzes the PR, and presents changes walkthrough for each component. See the tools guide for more details. To list the possible configuration parameters, add a /config comment.

See the describe usage page for a comprehensive guide on using this tool.

nx-cloud · 2024-02-10T04:41:13Z

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 80734da. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution

✅ Successfully ran 3 targets

Sent with 💌 from NxCloud.

rajdip-b · 2024-02-10T04:43:15Z

@HarshPatel5940 Awesome bro! Give me some time to go through the changes and test them.

package.json

HarshPatel5940 · 2024-02-10T04:48:00Z

@HarshPatel5940 Awesome bro! Give me some time to go through the changes and test them.

Definitely!

rajdip-b

About the logs, can you try to make them similar with what our existing login looks like? Just that it will start with [SENTRY]

.env.example

package.json

apps/api/src/main.ts

.gitignore

* it will not be enabled for `test` and `e2e`enviorment

codiumai-pr-agent-free · 2024-02-10T07:02:56Z

PR Description updated to latest commit (fc11cf9)

codiumai-pr-agent-free · 2024-02-10T07:03:13Z

PR Review

(Review updated until commit `4809f31`)

PR feedback
⏱️ Estimated effort to review [1-5]	3, because the PR involves integrating Sentry into an existing NestJS application, including configuration changes, environment variable setup, and Sentry-specific code additions. The complexity is moderate, with changes spanning multiple files, including configuration files and the main application bootstrap logic. Understanding the implications of these changes and ensuring they are correctly implemented requires a good understanding of both Sentry and NestJS.
🧪 Relevant tests	No
🔍 Possible issues	The Sentry initialization checks for `SENTRY_DSN` but does not validate other Sentry-related environment variables like `SENTRY_ORG`, `SENTRY_PROJECT`, and `SENTRY_AUTH_TOKEN`, which are crucial for source map uploads and might cause runtime errors if missing or incorrect. The use of `process.exit(1)` within `initializeSentry` could abruptly terminate the application without proper shutdown, potentially leading to resource leaks or unfinished asynchronous operations. The Sentry debug mode is enabled based on the `SENTRY_ENV` starting with 'dev', which might unintentionally enable debug mode for environments not strictly meant for development, such as 'dev-staging'.
🔒 Security concerns	No

Code feedback:

relevant file	apps/api/src/main.ts
suggestion	Consider validating all required Sentry environment variables (`SENTRY_ORG`, `SENTRY_PROJECT`, `SENTRY_AUTH_TOKEN`) at the start of `initializeSentry` to ensure they are present for source map uploads and other Sentry functionalities. This can prevent runtime errors and ensure smoother operation. [important]
relevant line	if (!process.env.SENTRY_DSN) {

relevant file	apps/api/src/main.ts
suggestion	Instead of using `process.exit(1)` directly within `initializeSentry`, consider throwing a custom error or using a more graceful shutdown process. This approach allows for cleanup operations and ensures that resources are properly released before the application terminates. [important]
relevant line	process.exit(1)

relevant file	apps/api/src/main.ts
suggestion	Refine the condition for enabling Sentry debug mode to explicitly check for a development environment, such as `process.env.SENTRY_ENV === 'development'`, to avoid unintentionally enabling debug mode in non-development environments. [medium]
relevant line	debug: process.env.SENTRY_ENV.startsWith('dev')

relevant file	apps/api/webpack.config.js
suggestion	Ensure that the `sentryWebpackPlugin` configuration includes `include` and `ignore` options to specify which files should be uploaded as source maps and which should be ignored. This can help reduce upload time and avoid uploading unnecessary files. [medium]
relevant line	sentryWebpackPlugin({

✨ Usage guide:

Overview:
The review tool scans the PR code changes, and generates a PR review. The tool can be triggered automatically every time a new PR is opened, or can be invoked manually by commenting on any PR.
When commenting, to edit configurations related to the review tool (pr_reviewer section), use the following template:

/review --pr_reviewer.some_config1=... --pr_reviewer.some_config2=...

With a configuration file, use the following template:

[pr_reviewer]
some_config1=...
some_config2=...

Utilizing extra instructions The `review` tool can be configured with extra instructions, which can be used to guide the model to a feedback tailored to the needs of your project. Be specific, clear, and concise in the instructions. With extra instructions, you are the prompter. Specify the relevant sub-tool, and the relevant aspects of the PR that you want to emphasize. Examples for extra instructions: `[pr_reviewer] # /review # extra_instructions=""" In the 'possible issues' section, emphasize the following: - Does the code logic cover relevant edge cases? - Is the code logic clear and easy to understand? - Is the code logic efficient? ... """` Use triple quotes to write multi-line instructions. Use bullet points to make the instructions more readable.
How to enable\disable automation When you first install PR-Agent app, the default mode for the `review` tool is: `pr_commands = ["/review", ...]` meaning the `review` tool will run automatically on every PR, with the default configuration. Edit this field to enable/disable the tool, or to change the used configurations
Auto-labels The `review` tool can auto-generate two specific types of labels for a PR: a `possible security issue` label, that detects possible security issues (`enable_review_labels_security` flag) a `Review effort [1-5]: x` label, where x is the estimated effort to review the PR (`enable_review_labels_effort` flag)
Extra sub-tools The `review` tool provides a collection of possible feedbacks about a PR. It is recommended to review the possible options, and choose the ones relevant for your use case. Some of the feature that are disabled by default are quite useful, and should be considered for enabling. For example: `require_score_review`, `require_soc2_ticket`, and more.
Auto-approve PRs By invoking: `/review auto_approve` The tool will automatically approve the PR, and add a comment with the approval. To ensure safety, the auto-approval feature is disabled by default. To enable auto-approval, you need to actively set in a pre-defined configuration file the following: `[pr_reviewer] enable_auto_approval = true` (this specific flag cannot be set with a command line argument, only in the configuration file, committed to the repository) You can also enable auto-approval only if the PR meets certain requirements, such as that the `estimated_review_effort` is equal or below a certain threshold, by adjusting the flag: `[pr_reviewer] maximal_review_effort = 5`
More PR-Agent commands To invoke the PR-Agent, add a comment using one of the following commands: /review: Request a review of your Pull Request. /describe: Update the PR title and description based on the contents of the PR. /improve [--extended]: Suggest code improvements. Extended mode provides a higher quality feedback. /ask <QUESTION>: Ask a question about the PR. /update_changelog: Update the changelog based on the PR's contents. /add_docs 💎: Generate docstring for new components introduced in the PR. /generate_labels 💎: Generate labels for the PR based on the PR's contents. /analyze 💎: Automatically analyzes the PR, and presents changes walkthrough for each component. See the tools guide for more details. To list the possible configuration parameters, add a /config comment.

See the review usage page for a comprehensive guide on using this tool.

codiumai-pr-agent-free · 2024-02-10T07:03:51Z

PR Code Suggestions

Suggestions

enhancement

Use environment variables for port configuration. Consider using environment variables for setting the port number instead of hardcoding it to ensure flexibility across different environments. apps/api/src/main.ts [79] -const port = 4200 +const port = process.env.PORT \|\| 4200
Improve naming for clarity in Sentry spans. Use a more descriptive name for the main span to clearly indicate its purpose or the specific operation it represents. apps/api/src/main.ts [59-60] -op: 'mainSpan', -name: 'My Main Span' +op: 'applicationBootstrap', +name: 'Application Bootstrap Process'

maintainability

Refactor Sentry setup into a separate function. Wrap the Sentry initialization and span creation in a separate function or module to improve code organization and readability. apps/api/src/main.ts [48-93] -Sentry.init({ - dsn: process.env.SENTRY_DSN, - ... -}) -await Sentry.startSpan( - { - op: 'mainSpan', - name: 'My Main Span' - }, - async () => { - ... - } -) +initializeSentry();

possible issue

Correct the Sentry source maps upload command for accuracy.

Ensure that the Sentry source maps upload command includes the correct path to the source
maps and verify the Sentry project configuration.

package.json [118]

-"sentry:sourcemaps": "sentry-cli sourcemaps inject ./dist && sentry-cli sourcemaps upload ./dist"
+"sentry:sourcemaps": "sentry-cli releases files <RELEASE_NAME> upload-sourcemaps ./dist --url-prefix '~/<PATH_TO_YOUR_SOURCEMAPS>' --validate"

best practice

Validate necessary environment variables early. Validate environment variables at the start of the application to ensure all required configurations are set. apps/api/src/main.ts [48-55] +if (!process.env.SENTRY_DSN) { + throw new Error('Missing environment variable: SENTRY_DSN'); +} Sentry.init({ dsn: process.env.SENTRY_DSN, ... })

✨ Usage guide:

Overview:
The improve tool scans the PR code changes, and automatically generates suggestions for improving the PR code. The tool can be triggered automatically every time a new PR is opened, or can be invoked manually by commenting on a PR.
When commenting, to edit configurations related to the improve tool (pr_code_suggestions section), use the following template:

/improve --pr_code_suggestions.some_config1=... --pr_code_suggestions.some_config2=...

With a configuration file, use the following template:

[pr_code_suggestions]
some_config1=...
some_config2=...

Enabling\disabling automation When you first install the app, the default mode for the improve tool is: `pr_commands = ["/improve --pr_code_suggestions.summarize=true", ...]` meaning the `improve` tool will run automatically on every PR, with summarization enabled. Delete this line to disable the tool from running automatically.
Utilizing extra instructions Extra instructions are very important for the `improve` tool, since they enable to guide the model to suggestions that are more relevant to the specific needs of the project. Be specific, clear, and concise in the instructions. With extra instructions, you are the prompter. Specify relevant aspects that you want the model to focus on. Examples for extra instructions: `[pr_code_suggestions] # /improve # extra_instructions=""" Emphasize the following aspects: - Does the code logic cover relevant edge cases? - Is the code logic clear and easy to understand? - Is the code logic efficient? ... """` Use triple quotes to write multi-line instructions. Use bullet points to make the instructions more readable.
A note on code suggestions quality While the current AI for code is getting better and better (GPT-4), it's not flawless. Not all the suggestions will be perfect, and a user should not accept all of them automatically. Suggestions are not meant to be simplistic. Instead, they aim to give deep feedback and raise questions, ideas and thoughts to the user, who can then use his judgment, experience, and understanding of the code base. Recommended to use the 'extra_instructions' field to guide the model to suggestions that are more relevant to the specific needs of the project, or use the custom suggestions 💎 tool With large PRs, best quality will be obtained by using 'improve --extended' mode.
More PR-Agent commands To invoke the PR-Agent, add a comment using one of the following commands: /review: Request a review of your Pull Request. /describe: Update the PR title and description based on the contents of the PR. /improve [--extended]: Suggest code improvements. Extended mode provides a higher quality feedback. /ask <QUESTION>: Ask a question about the PR. /update_changelog: Update the changelog based on the PR's contents. /add_docs 💎: Generate docstring for new components introduced in the PR. /generate_labels 💎: Generate labels for the PR based on the PR's contents. /analyze 💎: Automatically analyzes the PR, and presents changes walkthrough for each component. See the tools guide for more details. To list the possible configuration parameters, add a /config comment.

See the improve usage page for a more comprehensive guide on using this tool.

HarshPatel5940 · 2024-02-10T07:04:36Z

This should not be like this right? because all the functions are counted as bootstrap.

rajdip-b · 2024-02-10T07:34:37Z

This should not be like this right? because all the functions are counted as bootstrap.

I think it is bound to happen since all the modules are loaded in the AppModule, and it is in turn loaded in init.

What I wanted as to make sure that I can log the waterfalls, and the application errors. So I think this is good.

rajdip-b

All looks good, just make these last two changes:

Integrate this suggestion:

Use a more descriptive name for the main span to clearly indicate its purpose or the
specific operation it represents.
apps/api/src/main.ts [59-60]
-op: 'mainSpan',
-name: 'My Main Span'
+op: 'applicationBootstrap',
+name: 'Application Bootstrap Process'

Add SENTRY_ORG and SENTRY_DSN in .env.example

tsconfig.base.json

rajdip-b · 2024-02-10T07:45:14Z

Looks like the profiling worked, but the error wasn't logged :/

Mind testing out the above thing once?

* made it to follow DRY

HarshPatel5940 · 2024-02-10T07:58:21Z

Mind testing out the above thing once?

umm sure, let me try.

codiumai-pr-agent-free · 2024-02-17T04:24:53Z

Persistent review updated to latest commit 4f4f4ec

HarshPatel5940 · 2024-02-17T04:25:55Z

/improve

codiumai-pr-agent-free · 2024-02-17T04:26:02Z

PR Code Suggestions

Suggestions

enhancement

Implement proper error handling for the 'break' endpoint. Consider implementing proper error handling for the 'break' endpoint. Throwing a generic error directly in the controller can lead to unhandled exceptions and affect the stability of your application. You might want to use a service to handle the logic and catch errors appropriately. apps/api/src/app/app.controller.ts [14-18] @Get('break') @Public() -break(): string { - throw new Error('Broken') +async break(): Promise<string> { + try { + // Your logic here + } catch (error) { + // Handle error appropriately + } }
Improve error handling for Sentry source maps upload script. Ensure that the Sentry source maps upload script gracefully handles failures without breaking the build process. Consider adding more robust error handling or a notification mechanism to alert the team when the upload fails. package.json [118] -"sentry:sourcemaps": "sentry-cli sourcemaps inject ./dist && sentry-cli sourcemaps upload ./dist \|\| echo 'Failed to upload source maps to Sentry'" +"sentry:sourcemaps": "sentry-cli sourcemaps inject ./dist && sentry-cli sourcemaps upload ./dist \|\| (echo 'Failed to upload source maps to Sentry' && exit 1)"

security

Securely manage the Sentry DSN environment variable. Ensure that the Sentry DSN environment variable is securely managed and not hardcoded or exposed in your codebase. It's good practice to load sensitive information from environment variables or a secure configuration management system. apps/api/src/main.ts [47-51] -if (!process.env.SENTRY_DSN) { - Logger.error('Missing environment variable: SENTRY_DSN') - process.exit(1) -} +// Ensure SENTRY_DSN is loaded from a secure source

best practice

Ensure correct Sentry Webpack plugin configuration for source map uploads. Verify the Sentry Webpack plugin configuration to ensure that source maps are correctly uploaded in production builds. It's crucial for debugging production issues effectively. Additionally, consider handling the scenario where `process.env.NODE_ENV` is not set. apps/api/webpack.config.js [6-15] plugins: [ - ...((process.env.NODE_ENV \|\| 'production') === 'production' + ...((process.env.NODE_ENV === 'production') ? sentryWebpackPlugin({ org: process.env.SENTRY_ORG, project: process.env.SENTRY_PROJECT, authToken: process.env.SENTRY_AUTH_TOKEN }) : []) ]

documentation

Clarify and correct the description of NODE_ENV in the environment variables documentation.

Clarify the description of NODE_ENV to remove the redundant "The" and correct the spelling
of "environment". Also, consider providing more guidance on how this variable affects the
application's behavior in different environments.

docs/contributing-to-keyshade/environment-variables.md [11]

-* **NODE_ENV**: The The environment in which the app is running. It can be either 'development', 'production', or 'test'. Please note that it's not mandatory, it will default to "production" enviroment for the sentry configuration.
+* **NODE_ENV**: The environment in which the app is running. It can be either 'development', 'production', or 'test'. This variable influences how the application behaves and interacts with other services, such as Sentry, in different environments.

✨ Usage guide:

Overview:
The improve tool scans the PR code changes, and automatically generates suggestions for improving the PR code. The tool can be triggered automatically every time a new PR is opened, or can be invoked manually by commenting on a PR.
When commenting, to edit configurations related to the improve tool (pr_code_suggestions section), use the following template:

/improve --pr_code_suggestions.some_config1=... --pr_code_suggestions.some_config2=...

With a configuration file, use the following template:

[pr_code_suggestions]
some_config1=...
some_config2=...

Enabling\disabling automation When you first install the app, the default mode for the improve tool is: `pr_commands = ["/improve --pr_code_suggestions.summarize=true", ...]` meaning the `improve` tool will run automatically on every PR, with summarization enabled. Delete this line to disable the tool from running automatically.
Utilizing extra instructions Extra instructions are very important for the `improve` tool, since they enable to guide the model to suggestions that are more relevant to the specific needs of the project. Be specific, clear, and concise in the instructions. With extra instructions, you are the prompter. Specify relevant aspects that you want the model to focus on. Examples for extra instructions: `[pr_code_suggestions] # /improve # extra_instructions=""" Emphasize the following aspects: - Does the code logic cover relevant edge cases? - Is the code logic clear and easy to understand? - Is the code logic efficient? ... """` Use triple quotes to write multi-line instructions. Use bullet points to make the instructions more readable.
A note on code suggestions quality While the current AI for code is getting better and better (GPT-4), it's not flawless. Not all the suggestions will be perfect, and a user should not accept all of them automatically. Suggestions are not meant to be simplistic. Instead, they aim to give deep feedback and raise questions, ideas and thoughts to the user, who can then use his judgment, experience, and understanding of the code base. Recommended to use the 'extra_instructions' field to guide the model to suggestions that are more relevant to the specific needs of the project, or use the custom suggestions 💎 tool With large PRs, best quality will be obtained by using 'improve --extended' mode.
More PR-Agent commands To invoke the PR-Agent, add a comment using one of the following commands: /review: Request a review of your Pull Request. /describe: Update the PR title and description based on the contents of the PR. /improve [--extended]: Suggest code improvements. Extended mode provides a higher quality feedback. /ask <QUESTION>: Ask a question about the PR. /update_changelog: Update the changelog based on the PR's contents. /add_docs 💎: Generate docstring for new components introduced in the PR. /generate_labels 💎: Generate labels for the PR based on the PR's contents. /analyze 💎: Automatically analyzes the PR, and presents changes walkthrough for each component. See the tools guide for more details. To list the possible configuration parameters, add a /config comment.

See the improve usage page for a more comprehensive guide on using this tool.

rajdip-b · 2024-02-17T04:27:07Z

ok, nvm I got it to push my updates with 4f4f4ec

@rajdip-b Do you think this tests before commit can be improvised ? I can't think of anything right now. Maybe run these tests before push, so atleast user can play around locally? idk 🤷🏼

Yes I think I will remove precommit. it's annoying tbh

apps/api/src/app/app.controller.ts

apps/api/src/main.ts

apps/api/webpack.config.js

docs/contributing-to-keyshade/environment-variables.md

package.json

rajdip-b · 2024-02-17T04:42:29Z

@HarshPatel5940 i believe the tests have some caching issues. It usually passes if we re-run it, but we need to somehow fix that flakey test suit. It always happens in event.e2e.spec.ts

HarshPatel5940 · 2024-02-17T05:24:00Z

Will do the changes as soon as time permits.

@HarshPatel5940 i believe the tests have some caching issues. It usually passes if we re-run it, but we need to somehow fix that flakey test suit. It always happens in event.e2e.spec.ts

Hmmm, i see.

rajdip-b · 2024-02-17T05:57:16Z

Will do the changes as soon as time permits.

@HarshPatel5940 i believe the tests have some caching issues. It usually passes if we re-run it, but we need to somehow fix that flakey test suit. It always happens in event.e2e.spec.ts

Hmmm, i see.

No rush bro! You can raise a PR for that whenever you feel so!

* add `sentry_env` instead of `node_env`

rajdip-b · 2024-02-18T14:17:58Z

/review

codiumai-pr-agent-free · 2024-02-18T14:18:32Z

Persistent review updated to latest commit 4809f31

apps/api/src/main.ts

HarshPatel5940 · 2024-02-18T14:45:19Z

@rajdip-b sorry for the silly mistake at the end. I will be more careful from future to avoid those.

rajdip-b · 2024-02-18T14:51:19Z

@rajdip-b sorry for the silly mistake at the end. I will be more careful from future to avoid those.

Happens all the time on such major PRs! No issue on that. I'm making some final changes and make a push.

HarshPatel5940 · 2024-02-18T15:06:14Z

Happens all the time on such major PRs! No issue on that. I'm making some final changes and make a push.

Oh ok. noted.

sonarcloud · 2024-02-18T15:10:02Z

Quality Gate passed

Issues
0 New issues

Measures
0 Security Hotspots
No data about Coverage
4.8% Duplication on New Code

See analysis details on SonarCloud

rajdip-b

Guess that does it!

## [1.2.0](v1.1.0...v1.2.0) (2024-02-18) ### 🚀 Features * **api:** Add Sentry Integeration ([#133](#133)) ([5ae2c92](5ae2c92)) ### 🔧 Miscellaneous Chores * **api:** update dockerfile and ci ([ae2d944](ae2d944)) * **api:** update sentry log messages ([976026c](976026c)) * **ci:** update stage-api workflow ([addaa61](addaa61)) * **husky:** Remove `e2e:api` command from husky ([#144](#144)) ([8a2fa58](8a2fa58)) * update sentry source map script ([bdc9dc6](bdc9dc6))

rajdip-b · 2024-02-18T16:46:28Z

🎉 This PR is included in version 1.2.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

HarshPatel5940 added 2 commits February 10, 2024 09:54

feat: init sentry

8d372e0

chore: Add Sentry Handlers

5ee3373

HarshPatel5940 commented Feb 10, 2024

View reviewed changes

package.json Show resolved Hide resolved

rajdip-b requested changes Feb 10, 2024

View reviewed changes

.env.example Outdated Show resolved Hide resolved

package.json Show resolved Hide resolved

rajdip-b requested changes Feb 10, 2024

View reviewed changes

package.json Outdated Show resolved Hide resolved

HarshPatel5940 added 3 commits February 10, 2024 11:04

Remove NODE_ENV from .env.example

a35d571

chore: remove hardcoded values

7cf2ec9

chore: add default value

0cda94f

rajdip-b requested changes Feb 10, 2024

View reviewed changes

apps/api/src/main.ts Outdated Show resolved Hide resolved

.gitignore Show resolved Hide resolved

chore: add enabled check for sentry

fc11cf9

* it will not be enabled for `test` and `e2e`enviorment

HarshPatel5940 marked this pull request as ready for review February 10, 2024 07:02

codiumai-pr-agent-free bot added type: enhancement New feature or request configuration changes labels Feb 10, 2024

codiumai-pr-agent-free bot added the Review effort [1-5]: 3 label Feb 10, 2024

HarshPatel5940 requested a review from rajdip-b February 10, 2024 07:11

rajdip-b requested changes Feb 10, 2024

View reviewed changes

tsconfig.base.json Outdated Show resolved Hide resolved

HarshPatel5940 added 3 commits February 10, 2024 13:16

chore: remove comments

2494745

chore: Add SENTRY_ORG and SENTRY_PROJECT

28e7e8f

refactor: implement code suggestions

a6c41ad

* made it to follow DRY

codiumai-pr-agent-free bot added the Review effort [1-5]: 3 label Feb 17, 2024

rajdip-b requested changes Feb 17, 2024

View reviewed changes

chore: resolve comments

4809f31

* add `sentry_env` instead of `node_env`

HarshPatel5940 requested a review from rajdip-b February 18, 2024 12:10

rajdip-b requested changes Feb 18, 2024

View reviewed changes

apps/api/src/main.ts Outdated Show resolved Hide resolved

Refact: Sentry initialization logic

ea58f5d

HarshPatel5940 requested a review from rajdip-b February 18, 2024 14:28

rajdip-b requested changes Feb 18, 2024

View reviewed changes

apps/api/src/main.ts Outdated Show resolved Hide resolved

fix: Sentry env variable check

5606b96

HarshPatel5940 requested a review from rajdip-b February 18, 2024 14:43

final touches

80734da

rajdip-b approved these changes Feb 18, 2024

View reviewed changes

rajdip-b merged commit 5ae2c92 into keyshade-xyz:develop Feb 18, 2024
7 of 8 checks passed

HarshPatel5940 deleted the hp/feat/implement-sentry branch February 18, 2024 15:43

rajdip-b added the released label Feb 18, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(api): Add Sentry Integeration #133

feat(api): Add Sentry Integeration #133

HarshPatel5940 commented Feb 10, 2024 •

edited

Loading

nx-cloud bot commented Feb 10, 2024 •

edited

Loading

rajdip-b commented Feb 10, 2024

HarshPatel5940 commented Feb 10, 2024

rajdip-b left a comment

codiumai-pr-agent-free bot commented Feb 10, 2024

codiumai-pr-agent-free bot commented Feb 10, 2024 •

edited

Loading

codiumai-pr-agent-free bot commented Feb 10, 2024

HarshPatel5940 commented Feb 10, 2024

rajdip-b commented Feb 10, 2024

rajdip-b left a comment •

edited

Loading

rajdip-b commented Feb 10, 2024

HarshPatel5940 commented Feb 10, 2024

codiumai-pr-agent-free bot commented Feb 17, 2024

HarshPatel5940 commented Feb 17, 2024

codiumai-pr-agent-free bot commented Feb 17, 2024 •

edited

Loading

rajdip-b commented Feb 17, 2024

rajdip-b commented Feb 17, 2024

HarshPatel5940 commented Feb 17, 2024

rajdip-b commented Feb 17, 2024

rajdip-b commented Feb 18, 2024

codiumai-pr-agent-free bot commented Feb 18, 2024

HarshPatel5940 commented Feb 18, 2024

rajdip-b commented Feb 18, 2024

HarshPatel5940 commented Feb 18, 2024

sonarcloud bot commented Feb 18, 2024

rajdip-b left a comment

rajdip-b commented Feb 18, 2024

feat(api): Add Sentry Integeration #133

feat(api): Add Sentry Integeration #133

Conversation

HarshPatel5940 commented Feb 10, 2024 • edited Loading

User description

Description

Dependencies

Mentions

Screenshots of relevant screens

Developer's checklist

Documentation Update

Type

Description

Changes walkthrough

nx-cloud bot commented Feb 10, 2024 • edited Loading

☁️ Nx Cloud Report

rajdip-b commented Feb 10, 2024

HarshPatel5940 commented Feb 10, 2024

rajdip-b left a comment

Choose a reason for hiding this comment

codiumai-pr-agent-free bot commented Feb 10, 2024

codiumai-pr-agent-free bot commented Feb 10, 2024 • edited Loading

PR Review

(Review updated until commit 4809f31)

codiumai-pr-agent-free bot commented Feb 10, 2024

PR Code Suggestions

HarshPatel5940 commented Feb 10, 2024

rajdip-b commented Feb 10, 2024

rajdip-b left a comment • edited Loading

Choose a reason for hiding this comment

rajdip-b commented Feb 10, 2024

HarshPatel5940 commented Feb 10, 2024

codiumai-pr-agent-free bot commented Feb 17, 2024

HarshPatel5940 commented Feb 17, 2024

codiumai-pr-agent-free bot commented Feb 17, 2024 • edited Loading

PR Code Suggestions

rajdip-b commented Feb 17, 2024

rajdip-b commented Feb 17, 2024

HarshPatel5940 commented Feb 17, 2024

rajdip-b commented Feb 17, 2024

rajdip-b commented Feb 18, 2024

codiumai-pr-agent-free bot commented Feb 18, 2024

HarshPatel5940 commented Feb 18, 2024

rajdip-b commented Feb 18, 2024

HarshPatel5940 commented Feb 18, 2024

sonarcloud bot commented Feb 18, 2024

Quality Gate passed

rajdip-b left a comment

Choose a reason for hiding this comment

rajdip-b commented Feb 18, 2024

HarshPatel5940 commented Feb 10, 2024 •

edited

Loading

nx-cloud bot commented Feb 10, 2024 •

edited

Loading

codiumai-pr-agent-free bot commented Feb 10, 2024 •

edited

Loading

(Review updated until commit `4809f31`)

rajdip-b left a comment •

edited

Loading

codiumai-pr-agent-free bot commented Feb 17, 2024 •

edited

Loading