Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

API: Change OTP code from alphanumeric to numeric #211

Closed
rajdip-b opened this issue May 12, 2024 · 3 comments · Fixed by #230
Closed

API: Change OTP code from alphanumeric to numeric #211

rajdip-b opened this issue May 12, 2024 · 3 comments · Fixed by #230
Labels
good first issue Good for newcomers priority: medium scope: api Everything related to the API type: enhancement New feature or request

Comments

@rajdip-b
Copy link
Member

Description

Currently, the API sends an OTP while signing in or signing up with an email address. The problem isl, as per the standards, we should be sending a numeric OTP. But currently, it is alphanumeric. We would like to make this change.

Solution

Additional context

Make sure the tests pass. You won't need to add any other tests for this issue.
@rajdip-b rajdip-b added type: enhancement New feature or request good first issue Good for newcomers scope: api Everything related to the API priority: medium labels May 12, 2024
@lakshay-saini-au8
Copy link
Contributor

@rajdip-b Please assign this issue

@Ritika1705 Ritika1705 mentioned this issue May 19, 2024
Merged
10 tasks
@rajdip-b
Copy link
Member Author

Hey @lakshay-saini-au8, #230 fixes it, so I am removing your assignment.

@rajdip-b
Copy link
Member Author

🎉 This issue has been resolved in version 1.4.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers priority: medium scope: api Everything related to the API type: enhancement New feature or request
Projects
keyshade-api
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

refactor(api): Replaced OTP code from alphanumeric to numeric Ritika1705/keyshade
2 participants
@lakshay-saini-au8 @rajdip-b