Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(web): Docker next config not found #228

Merged
merged 1 commit into from
May 19, 2024
Merged

fix(web): Docker next config not found #228

merged 1 commit into from
May 19, 2024

Conversation

kriptonian1
Copy link
Contributor

@kriptonian1 kriptonian1 commented May 19, 2024 •
edited by codiumai-pr-agent-free bot
Loading

User description

Description

Give a summary of the change that you have made

Fixes #[ISSUENO]

Dependencies

Mention any dependencies/packages used

Future Improvements

Mention any improvements to be done in future related to any file/feature

Mentions

Mention and tag the people

Screenshots of relevant screens

Add screenshots of relevant screens

Developer's checklist

  • My PR follows the style guidelines of this project
  • I have performed a self-check on my work

If changes are made in the code:

  • I have followed the coding guidelines
  • My changes in code generate no new warnings
  • My changes are breaking another fix/feature of the project
  • I have added test cases to show that my feature works
  • I have added relevant screenshots in my PR
  • There are no UI/UX issues

Documentation Update

  • This PR requires an update to the documentation at docs.keyshade.xyz
  • I have made the necessary updates to the documentation, or no documentation changes are required.

PR Type

bug_fix

Description

  • Corrected the Dockerfile to copy the correct next.config.mjs instead of next.config.js, resolving the build failure issue.

Changes walkthrough 📝

Relevant files
Bug fix
Dockerfile
Fix Docker Build by Correcting Config File Extension         

apps/web/Dockerfile

  • Changed the copied file from next.config.js to next.config.mjs to
    match the expected module file in the Docker build process.
    		•  +1/-1     

    💡 PR-Agent usage:
    Comment /help on the PR to get a list of all available PR-Agent tools and their descriptions

    @kriptonian1 kriptonian1 requested a review from rajdip-b May 19, 2024 06:22
    @codiumai-pr-agent-free CodiumAI PR-Agent (Free)
    Copy link
    Contributor

    PR Description updated to latest commit (f83dc48)

    @codiumai-pr-agent-free CodiumAI PR-Agent (Free)
    Copy link
    Contributor

    PR Review 🔍

    ⏱️ Estimated effort to review [1-5]

    1, because the PR involves a simple change in the Dockerfile, specifically updating the file extension from .js to .mjs. This is a straightforward change with a clear purpose, and it does not involve complex logic or multiple files.

    🧪 Relevant tests

    No

    ⚡ Possible issues

    No

    🔒 Security concerns

    No

    @sonarcloud SonarCloud
    Copy link

    sonarcloud bot commented May 19, 2024

    Quality Gate Passed Quality Gate passed

    Issues
    0 New issues
    0 Accepted issues

    Measures
    0 Security Hotspots
    No data about Coverage
    0.0% Duplication on New Code

    See analysis details on SonarCloud

    @codiumai-pr-agent-free CodiumAI PR-Agent (Free)
    Copy link
    Contributor

    PR Code Suggestions ✨

    CategorySuggestion                                                                                                                                    Score
    Possible issue
    Verify and ensure the file extension for Next.js configuration is correct to avoid runtime issues

    Ensure that the file extension change from .js to .mjs for next.config is intentional and
    supported by your Next.js setup. Next.js typically uses .js or .ts for its configuration
    files. If .mjs is not configured properly, it might not be recognized, causing runtime
    issues.

    apps/web/Dockerfile [41]

    -COPY --from=installer /app/apps/web/next.config.mjs .
+COPY --from=installer /app/apps/web/next.config.js .
    Suggestion importance[1-10]: 8

    Why: The suggestion correctly identifies a potential critical issue with the change from .js to .mjs in the Next.js configuration file, which could lead to runtime errors if not properly supported.

    		8

    @kriptonian1 kriptonian1 enabled auto-merge (squash) May 19, 2024 06:25
    @rajdip-b rajdip-b changed the title fix(web): docker next config not found fix(web): Docker next config not found May 19, 2024
    @kriptonian1 kriptonian1 merged commit afe3160 into develop May 19, 2024
    9 checks passed
    @rajdip-b rajdip-b deleted the web-build-fail branch May 19, 2024 06:37
    rajdip-b pushed a commit that referenced this pull request May 24, 2024
    @semantic-release-bot
    chore(release): 1.4.0 [skip ci]
    55862df 
    ## [1.4.0](v1.3.0...v1.4.0) (2024-05-24)

### 🚀 Features

* add example for health and email auth ([b834d25](b834d25))
* **api:** Add `minio-client` provider ([#237](#237)) ([cd71c5a](cd71c5a))
* **api:** Add feature to fork projects ([#239](#239)) ([3bab653](3bab653))
* **api:** Added feedback form module ([#210](#210)) ([ae1efd8](ae1efd8))
* **api:** Added Project Level Access  ([#221](#221)) ([564f5ed](564f5ed))
* **api:** Added support for changing email of users ([#233](#233)) ([5ea9a10](5ea9a10))
* implemented auth, ui for most, and fixed cors ([#217](#217)) ([feace86](feace86))
* **platfrom:** add delete method in api client ([#225](#225)) ([55cf09f](55cf09f))
* **postman:** add example for get_self and update_self ([e015acf](e015acf))
* **web:** Add and link privacy and tnc page ([#226](#226)) ([ec81eb9](ec81eb9))

### 🐛 Bug Fixes

* **web:** docker next config not found ([#228](#228)) ([afe3160](afe3160))

### 📚 Documentation

* Added docs regarding postman, and refactored architecture diagrams ([f1c9777](f1c9777))
* Fix typo in organization-of-code.md ([#234](#234)) ([11244a2](11244a2))

### 🔧 Miscellaneous Chores

* **api:** Get feedback forward email from process.env ([#236](#236)) ([204c9d1](204c9d1))
* **postman:** Initialized postman ([bb76384](bb76384))
* **release:** Update changelog config ([af91283](af91283))
* Remove swagger docs ([#220](#220)) ([7640299](7640299))

### 🔨 Code Refactoring

* **api:** Replaced OTP code from alphanumeric to numeric ([#230](#230)) ([f16162a](f16162a))
    @rajdip-b
    Copy link
    Member

    🎉 This PR is included in version 1.4.0 🎉

    The release is available on GitHub release

    Your semantic-release bot 📦🚀

    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Reviewers

    @rajdip-b rajdip-b rajdip-b approved these changes

    Assignees
    No one assigned
    Labels
    Review effort [1-5]: 1
    Projects
    None yet
    Milestone
    No milestone
    Development

    Successfully merging this pull request may close these issues.
    2 participants
    @kriptonian1 @rajdip-b