-
-
Notifications
You must be signed in to change notification settings - Fork 105
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PLATFORM: Add Dockerfile
to platform
#259
Comments
Hi, @rajdip-b this seems to be an interesting issue to solve can you pls. mind assigning me. In past I have exp. of dockerising JSON Schema Org. website which is built on the similar tech stack keyshade is built on |
We would be glad to @DhairyaMajmudar! All the best! |
Thanks will give my best |
Also @rajdip-b can you pls. also add this issue in the FossHack issue board. |
Sure thing boss! |
Thanks, man, you are awsm =) |
@rajdip-b the docker file is ready but I am facing a lot of build failures due to type-checks, Shall I incorporate the changes in the same PR or open a new issue? EDIT: Total type errors in platform folder, checked using script |
I would say, if it's avoidable, then just let it be like this for now. We can always iterate over this. But if this PR requires this type check to pass, then you can put up the implementation in the same PR. Totally depends upon how you want it to be done! |
Removing my assignment since this issue is resolved. |
Description
We would like to containerize the
platform
package. Add a dockerfile to this package.Solution
/apps/package
. You can refer to thispackage.json
:docker:build:platform
anddocker:run:platform
. Refer to chore: Added docker build and run commands topackage.json
#258The text was updated successfully, but these errors were encountered: