Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PLATFORM: Add Dockerfile to platform #259

Closed
rajdip-b opened this issue Jun 6, 2024 · 9 comments
Closed

PLATFORM: Add Dockerfile to platform #259

rajdip-b opened this issue Jun 6, 2024 · 9 comments
Labels
difficulty: 2 foss hack Clustering all the curated issues for Foss Hack 2024 good first issue Good for newcomers priority: medium scope: platform Everything related to the keyshade platform package type: chore Release drafter tag for tagging PRs related to making patches to general code

Comments

@rajdip-b
Copy link
Member

rajdip-b commented Jun 6, 2024

Description

We would like to containerize the platform package. Add a dockerfile to this package.

Solution

@rajdip-b rajdip-b added good first issue Good for newcomers type: chore Release drafter tag for tagging PRs related to making patches to general code scope: platform Everything related to the keyshade platform package priority: medium difficulty: 2 foss hack Clustering all the curated issues for Foss Hack 2024 labels Jun 6, 2024
@DhairyaMajmudar
Copy link
Contributor

Hi, @rajdip-b this seems to be an interesting issue to solve can you pls. mind assigning me. In past I have exp. of dockerising JSON Schema Org. website which is built on the similar tech stack keyshade is built on
Thank you : )

@rajdip-b
Copy link
Member Author

We would be glad to @DhairyaMajmudar! All the best!

@rajdip-b rajdip-b removed the foss hack Clustering all the curated issues for Foss Hack 2024 label Jun 20, 2024
@DhairyaMajmudar
Copy link
Contributor

We would be glad to @DhairyaMajmudar! All the best!

Thanks will give my best

@DhairyaMajmudar
Copy link
Contributor

Also @rajdip-b can you pls. also add this issue in the FossHack issue board.

@rajdip-b
Copy link
Member Author

Sure thing boss!

@rajdip-b rajdip-b added the foss hack Clustering all the curated issues for Foss Hack 2024 label Jun 20, 2024
@DhairyaMajmudar
Copy link
Contributor

Thanks, man, you are awsm =)

@DhairyaMajmudar
Copy link
Contributor

DhairyaMajmudar commented Jun 20, 2024

@rajdip-b the docker file is ready but I am facing a lot of build failures due to type-checks, Shall I incorporate the changes in the same PR or open a new issue?

image

EDIT: Total type errors in platform folder, checked using script tsc --noEmit
image

@rajdip-b
Copy link
Member Author

I would say, if it's avoidable, then just let it be like this for now. We can always iterate over this. But if this PR requires this type check to pass, then you can put up the implementation in the same PR. Totally depends upon how you want it to be done!

@DhairyaMajmudar
Copy link
Contributor

Removing my assignment since this issue is resolved.

@DhairyaMajmudar DhairyaMajmudar removed their assignment Jul 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
difficulty: 2 foss hack Clustering all the curated issues for Foss Hack 2024 good first issue Good for newcomers priority: medium scope: platform Everything related to the keyshade platform package type: chore Release drafter tag for tagging PRs related to making patches to general code
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants