Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Assumes process implies process.versions.node #16

Open
dobesv opened this issue Jan 29, 2022 · 0 comments · May be fixed by #17
Open

Assumes process implies process.versions.node #16

dobesv opened this issue Jan 29, 2022 · 0 comments · May be fixed by #17

Comments

@dobesv
Copy link

dobesv commented Jan 29, 2022

We are simulating process in the browser using https://github.com/defunctzombie/node-process/blob/master/browser.js . It doesn't have process.versions.node in it, so this check over here gives an error: https://github.com/keyz/identity-obj-proxy/blob/master/src/index.js#L10

It would be nice if the code were updated to handle the case where process.versions.node is set even if process is not.

@dobesv dobesv linked a pull request Jan 29, 2022 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant