Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

separate netinfo from React native & import from react native community #220

Open
Qasim-Yousaf opened this issue Nov 9, 2021 · 0 comments

Comments

@Qasim-Yousaf
Copy link

Hi! 👋

Firstly, thanks for your work on this project! 🙂

Today I used patch-package to patch react-native-cached-image@1.4.3 for the project I'm working on.

Here is the diff that solved my problem:

diff --git a/node_modules/react-native-cached-image/CachedImage.js b/node_modules/react-native-cached-image/CachedImage.js
index daf03c8..31cbe6f 100644
--- a/node_modules/react-native-cached-image/CachedImage.js
+++ b/node_modules/react-native-cached-image/CachedImage.js
@@ -16,11 +16,15 @@ const {
     View,
     ImageBackground,
     ActivityIndicator,
-    NetInfo,
+   
     Platform,
     StyleSheet,
 } = ReactNative;
 
+
+
+const NetInfo = require('@react-native-community/netinfo')
+
 const styles = StyleSheet.create({
     image: {
         backgroundColor: 'transparent'
@@ -79,12 +83,18 @@ class CachedImage extends React.Component {
 
     componentWillMount() {
         this._isMounted = true;
-        NetInfo.isConnected.addEventListener('connectionChange', this.handleConnectivityChange);
+
+        NetInfo.addEventListener(state => {
+            this.handleConnectivityChange(state.isConnected)
+          });
+
+        // NetInfo.addEventListener('connectionChange', this.handleConnectivityChange);
+
         // initial
-        NetInfo.isConnected.fetch()
-            .then(isConnected => {
+        NetInfo.fetch()
+            .then(state => {
                 this.safeSetState({
-                    networkAvailable: isConnected
+                    networkAvailable: state.isConnected
                 });
             });
 
@@ -93,7 +103,10 @@ class CachedImage extends React.Component {
 
     componentWillUnmount() {
         this._isMounted = false;
-        NetInfo.isConnected.removeEventListener('connectionChange', this.handleConnectivityChange);
+        // NetInforemoveEventListener(state => {
+        //     this.handleConnectivityChange(state.isConnected)
+        //   });
+        // NetInfo.removeEventListener('connectionChange', this.handleConnectivityChange);
     }
 
     componentWillReceiveProps(nextProps) {

This issue body was partially generated by patch-package.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant