TestMatchLabels Is Consistently Failing

[danehans]

Which tests failed?

TestWatchNamespaceSelector/WatchNamespaceSelector/TestMatchLabels

Initial Investigation

This test has repeatedly failed for solo-io#10140 even though the PR does not appear to effect the codepath associated with this test. I have reproduced the same test failure locally using the main branch:

$ GOLANG_PROTOBUF_REGISTRATION_CONFLICT=ignore go test -v -timeout 600s ./test/kubernetes/e2e/tests -run ^TestWatchNamespaceSelector$
...
stderr:*   Trying 10.96.94.168:80...
* Connected to gateway-proxy.namespace-selector.svc.cluster.local (10.96.94.168) port 80 (#0)
> GET / HTTP/1.1
> Host: random
> User-Agent: curl/7.83.1-DEV
> Accept: */*
>
* Mark bundle as not supporting multiuse
< HTTP/1.1 200 OK
< content-length: 13
< content-type: text/plain
< date: Wed, 02 Oct 2024 22:49:09 GMT
< server: envoy
<
{ [13 bytes data]
* Connection #0 to host gateway-proxy.namespace-selector.svc.cluster.local left intact


=== NAME  TestWatchNamespaceSelector
    curl.go:140:
        Failed after 0.334s.
        The function passed to Consistently failed at /Users/solo-system-dhansen/go/src/github.com/solo-io/gloo/test/kubernetes/testutils/assertions/curl.go:134 with:
        Expected
            <*http.Response>: {
                Status:     <string>: ""
                StatusCode: <int>: 200
                Body:       <string>: "Hello, world!"
            }
        to have HTTP status
            <int>: 404

        expected: {
          "StatusCode": 404,
          "Body": null,
          "Headers": null,
          "Custom": null
        }
virtualservice.gateway.solo.io "vs-random" deleted
namespace "random" deleted
=== NAME  TestWatchNamespaceSelector/WatchNamespaceSelector/TestMatchLabels
    testing.go:1577: test executed panic(nil) or runtime.Goexit: subtest may have called FailNow on a parent test
virtualservice.gateway.solo.io "vs-install-ns" deleted
namespace "curl" deleted
pod "curl" deleted
=== NAME  TestWatchNamespaceSelector/WatchNamespaceSelector
    testing.go:1577: test executed panic(nil) or runtime.Goexit: subtest may have called FailNow on a parent test
"Wed, 02 Oct 2024 15:49:58 PDT: github.com/solo-io/gloo/test/kubernetes/testutils/helper/install.go:452"	uninstalling gloo...
  Uninstalling Gloo Gateway...
  Removing Gloo system components from namespace namespace-selector...
  Removing Gloo CRDs...
  Removing namespace namespace-selector... Done.

  Gloo was successfully uninstalled.
--- FAIL: TestWatchNamespaceSelector (149.50s)
    --- FAIL: TestWatchNamespaceSelector/WatchNamespaceSelector (68.40s)
        --- PASS: TestWatchNamespaceSelector/WatchNamespaceSelector/TestMatchExpressions (20.08s)
        --- FAIL: TestWatchNamespaceSelector/WatchNamespaceSelector/TestMatchLabels (5.15s)
FAIL
FAIL	github.com/solo-io/gloo/test/kubernetes/e2e/tests	149.589s
FAIL

Additional Information

The failing test was included in a PR that merged yesterday (10/1/24) via solo-io#10104.

┆Issue is synchronized with this Asana task by Unito

[danehans]

@davidjumani when you have a moment, PTAL since you added #10104.

[danehans]

I confirmed locally that solo-io#10104 fixed this issue:

$ GOLANG_PROTOBUF_REGISTRATION_CONFLICT=ignore go test -v -timeout 600s ./test/kubernetes/e2e/tests -run ^TestWatchNamespaceSelector$
...
  Gloo was successfully uninstalled.
--- PASS: TestWatchNamespaceSelector (232.58s)
    --- PASS: TestWatchNamespaceSelector/WatchNamespaceSelector (131.88s)
        --- PASS: TestWatchNamespaceSelector/WatchNamespaceSelector/TestMatchExpressions (32.40s)
        --- PASS: TestWatchNamespaceSelector/WatchNamespaceSelector/TestMatchLabels (30.38s)
        --- PASS: TestWatchNamespaceSelector/WatchNamespaceSelector/TestUnwatchedNamespaceValidation (5.17s)
        --- PASS: TestWatchNamespaceSelector/WatchNamespaceSelector/TestWatchedNamespaceValidation (20.87s)
PASS
ok  	github.com/solo-io/gloo/test/kubernetes/e2e/tests	232.672s

[davidjumani]

Fixed in solo-io#10160 && solo-io#10162